Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global search beta follow up #41381

Closed
20 of 22 tasks
nfebe opened this issue Nov 10, 2023 · 19 comments · Fixed by #41384 or #42167
Closed
20 of 22 tasks

Global search beta follow up #41381

nfebe opened this issue Nov 10, 2023 · 19 comments · Fixed by #41384 or #42167
Assignees
@nfebe
Labels
accessibility enhancement feature: search ❄️ 2023-Winter
Milestone
Nextcloud 28.0.1

Comments

@nfebe
Copy link
Contributor

nfebe commented Nov 10, 2023 •
edited
Loading

Follow up issues from #40823

TODO

High priority:

  • Typing in the user search filter doesn't show all the users, it seems that it shows only the preloaded ones
  • When filtering the local view (e.g. users) it's impossible to reset the view. When reopening the search modal, it should be possible to reset the search.
  • Search result links that should be improved to be actual links for a11y reasons

Other:

  • Icon inversion which does not work well now since icons come in white or black instead of one consistent color. (Black icons turn white and white icons turn black, leading to to white on white background issues)
  • Use the new people filter (selector) that @marcoambrosini is working on (Current people filter not completed) - DONE, however, NcPopover which is used has issues with closing triggers.
  • Update back-end API (if ability not already present) to show "Search in App" dynamically.
  • Remove person filter
  • BUG: Clicking outside the search modal needs two clicks on the magnifier icon to get the modal back.
  • BUG: Some app icons are white on white.
  • BUG: Modified timestamp bubbles change size on hover, have no pointing cursor.
  • BUG: Generally no feedback for no results.
  • BUG: Search people has white text on white background.
  • BUG: Search people has a tiny user bubble, barely wider than the avatar.
  • BUG: Search people No result goes to the top, overlaps other input.
  • BUG: Search people has no effect at all. The search string doesn't contain a person identifier.
  • Avatars are square. I guess that's because all previews are square so this makes sense technically. For a user, this is inconsistent with avatars, though
    image
  • When previews do not exist (endpoint returns 404) the browser renders a placeholder for the broken image
    Bildschirmfoto vom 2023-11-14 14-23-13
  • x on apps/person selection changes size on hover
  • No space for icons in modified (Fenn-CS : Best handled at component level, migrate to vue lib repo? "Do not reserve space for icon in NcActionButton if no icon is provided"???)
  • x on apps/person selection should have pointing cursor

image

  • People are not sorted, at least not by name
    image

  • Accidentally clicked the magnifier on mobile and found out it's impossible to close the modal
    image

Needs full page reload to get back to the content.
@nfebe nfebe added bug enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: search labels Nov 10, 2023
@nfebe nfebe self-assigned this Nov 10, 2023
@nfebe nfebe removed bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 10, 2023
@nfebe nfebe moved this to 🏗️ In progress in 📁 Files team Nov 10, 2023
@nfebe nfebe added this to the Nextcloud 28 milestone Nov 10, 2023
nfebe added a commit that referenced this issue Nov 10, 2023
@nfebe
Enhancements : improve most recent global search UI
e6032af 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@nfebe nfebe mentioned this issue Nov 10, 2023
Merged
12 tasks
nfebe added a commit that referenced this issue Nov 10, 2023
@nfebe
Enhancements : improve most recent global search UI
97d5956 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@marcoambrosini marcoambrosini mentioned this issue Nov 13, 2023
Merged
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Enhancements : improve most recent global search UI
3d0802f 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Enhancements : improve most recent global search UI
f307877 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Global search : Fix basic functional issues
0dafefd 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@ChristophWurst

This comment was marked as outdated.

Sign in to view
@ChristophWurst

This comment was marked as outdated.

Sign in to view
@ChristophWurst

This comment was marked as outdated.

Sign in to view
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Global search : Fix basic functional issues
ba6f6be 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Global search : Fix basic functional issues
c9064b4 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
nfebe added a commit that referenced this issue Nov 14, 2023
@nfebe
Global search : Fix basic functional issues
5a4cc8c 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : #41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Nov 14, 2023
@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do (~10 entries) in 📁 Files team Nov 15, 2023
@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 15, 2023 •
edited by nfebe
Loading

  • Search result have a href of #. Opening them in a new tab brings you to the same page you were when searching, not the search result. This is probably an a11y issue too.

@SystemKeeper
Copy link
Contributor

SystemKeeper commented Nov 24, 2023 •
edited by nfebe
Loading

  • When clicking on a search result (e.g. Talk or Files) you don't jump to that file/conversation anymore, instead:
    image

@ChristophWurst
Copy link
Member

When clicking on a search result

TypeError: t.openResult is not a function
    click SearchResult.vue:1
    VueJS 4
    onClick NcListItem.mjs:171
    click NcListItem.mjs:223
    VueJS 3

Same for results of Mail and other search providers

@ChristophWurst
Copy link
Member

ChristophWurst commented Nov 27, 2023 •
edited by nfebe
Loading

  • BUG modal can only be opened once, then it auto-closes
  1. Click magnifier icon
  2. Click outside the modal
  3. Click magnifier icon again
  4. Nothing happens
  5. Click magnifier icon again
  6. Modal opens, closes again
  7. goto 3.

@nfebe
Copy link
Contributor Author

nfebe commented Nov 28, 2023

When clicking on a search result (e.g. Talk or Files) you don't jump to that file/conversation anymore, instead:

Resolved in : #41785

@ChristophWurst ChristophWurst mentioned this issue Nov 28, 2023
Merged
@nfebe nfebe mentioned this issue Nov 28, 2023
Merged
@ChristophWurst
Copy link
Member

#41381 (comment) still happens and it's quite frustrating to have to reload the page every time I mislick the notification icon.

@Altahrim

This comment was marked as outdated.

Sign in to view
@jancborchardt
Copy link
Member

jancborchardt commented Dec 4, 2023 •
edited by nfebe
Loading

  • When using the "Filter current view" in account management, it is not possible to reset the search. E.g. on tech-preview, opening the modal back again makes it come up with an already cleared search input so it is not clearable. But the search term is still applied in the main content behind the modal, as well as for e.g. the Giphy provider inside the modal.

@jancborchardt jancborchardt moved this to 🏗️ At engineering in 🖍 Design team Dec 4, 2023
@jancborchardt jancborchardt moved this from 🏗️ At engineering to 🕶️ Design review in 🖍 Design team Dec 4, 2023
@jancborchardt
Copy link
Member

jancborchardt commented Dec 11, 2023 •
edited by nfebe
Loading

  • "Start typing in search" → "Start typing to search"
  • When clearing the search term by marking the whole thing and deleting it all in one, the results stay below the emptycontent view:
    image

@nfebe nfebe mentioned this issue Dec 11, 2023
Merged
@jancborchardt jancborchardt mentioned this issue Dec 12, 2023
Closed
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 28.0.1 Dec 12, 2023
@github-project-automation github-project-automation bot moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Dec 13, 2023
@github-project-automation github-project-automation bot moved this from 🕶️ Design review to 🎉 Done in 🖍 Design team Dec 13, 2023
zak39 pushed a commit to zak39/server that referenced this issue Dec 19, 2023
@nfebe @zak39
Global search : Fix basic functional issues
55c6dab 
- Fixes remove person filter/chip when applied
- Close person searchable filter via workaround
- Person filter has no effect fixed, now uses user property instead of id
- Left align filters
- Reduce avatar size in user chip and make photo non-clickable

Resolves : nextcloud#41381

Signed-off-by: fenn-cs <fenn25.fn@gmail.com>
@ChristophWurst
Copy link
Member

Accidentally clicked the magnifier on mobile and found out it's impossible to close the modal

image

@github-project-automation github-project-automation bot moved this from ☑️ Done to 📄 To do (~10 entries) in 📁 Files team Dec 22, 2023
@nfebe
Copy link
Contributor Author

nfebe commented Dec 22, 2023

@ChristophWurst we have this already #41422

@nfebe nfebe closed this as completed Dec 22, 2023
@github-project-automation github-project-automation bot moved this from 📄 To do (~10 entries) to ☑️ Done in 📁 Files team Dec 22, 2023
@ChristophWurst
Copy link
Member

Thanks. It was not clear from this ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nfebe nfebe

Labels
accessibility enhancement feature: search ❄️ 2023-Winter
Projects
📁 Files team
Archived in project
🖍 Design team
Archived in project
Milestone
Nextcloud 28.0.1
7 participants
@jancborchardt @AndyScherzinger @ChristophWurst @SystemKeeper @blizzz @Altahrim @nfebe