Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate renaming by clicking outside the name #42689

Closed
raphj opened this issue Jan 10, 2024 · 0 comments · Fixed by #44819
Closed

Validate renaming by clicking outside the name #42689

raphj opened this issue Jan 10, 2024 · 0 comments · Fixed by #44819
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files

Comments

@raphj
Copy link

raphj commented Jan 10, 2024

Is your feature request related to a problem? Please describe.

I saw somebody trying to rename a file by typing the new name and then clicking outside the input.
They expected the rename to be taken in account. This would be consistent with most file managers I know, including Dolphin (KDE), and most probably Mac's Finder too.

The actual result is that the rename is canceled. One needs to type Enter for the file to be actually renamed. This person actually thought Nextcloud was having an issue. They actually tried 3 times in a row.

Describe the solution you'd like

The rename should be taken in account when clicking outside the file input.

Describe alternatives you've considered

None

Additional context

Nextcloud.rename.mp4
dolphin.rename.mp4

See also #44832

@raphj raphj added 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jan 10, 2024
raphj pushed a commit to raphj/nextcloud_server that referenced this issue Apr 14, 2024
Refs: nextcloud#42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
raphj pushed a commit to raphj/nextcloud_server that referenced this issue Apr 15, 2024
Refs: nextcloud#42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
szaimen pushed a commit to raphj/nextcloud_server that referenced this issue Apr 29, 2024
Refs: nextcloud#42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
skjnldsv pushed a commit to raphj/nextcloud_server that referenced this issue May 2, 2024
Refs: nextcloud#42689

Signed-off-by: Raphaël Jakse <raphael.git@jakse.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: files
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants