[Bug]: `\OC\Files\View::hash()`: Return value must be of type `string|bool`, `null` returned #44110

solracsf · 2024-03-10T13:16:54Z

⚠️ This issue respects the following points: ⚠️

This is a bug, not a question or a configuration/webserver/proxy issue.
This issue is not already reported on Github OR Nextcloud Community Forum (I've searched it).
Nextcloud Server is up to date. See Maintenance and Release Schedule for supported versions.
I agree to follow Nextcloud's Code of Conduct.

Bug description

Log is spammed with hundreds of these errors. I don't really know how to reproduce them, or any side effects.

Steps to reproduce

No idea.

Expected behavior

No errors.

Installation method

Community Web installer on a VPS or web space

Nextcloud Server version

27

Operating system

Debian/Ubuntu

PHP engine version

PHP 8.2

Web server

Apache (supported)

Database engine version

MariaDB

Is this bug present after an update or on a fresh install?

Upgraded to a MAJOR version (ex. 22 to 23)

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

What user-backends are you using?

Default user-backend (database)
LDAP/ Active Directory
SSO - SAML
Other

Configuration report

# occ config:list system
{
    "system": {
        "instanceid": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpmode": "smtp",
        "mail_smtpsecure": "tls",
        "mail_smtpauthtype": "LOGIN",
        "mail_sendmailmode": "smtp",
        "mail_from_address": "***REMOVED SENSITIVE VALUE***",
        "mail_domain": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpauth": 1,
        "mail_smtphost": "***REMOVED SENSITIVE VALUE***",
        "mail_smtpport": "587",
        "mail_smtpname": "***REMOVED SENSITIVE VALUE***",
        "mail_smtppassword": "***REMOVED SENSITIVE VALUE***",
        "dbtype": "mysql",
        "dbtableprefix": "oc_",
        "mysql.utf8mb4": true,
        "dbname": "***REMOVED SENSITIVE VALUE***",
        "dbhost": "***REMOVED SENSITIVE VALUE***",
        "dbuser": "***REMOVED SENSITIVE VALUE***",
        "dbpassword": "***REMOVED SENSITIVE VALUE***",
        "trusted_proxies": "***REMOVED SENSITIVE VALUE***",
        "redis": {
            "host": "***REMOVED SENSITIVE VALUE***",
            "port": 0
        },
        "memcache.local": "\\OC\\Memcache\\Redis",
        "memcache.locking": "\\OC\\Memcache\\Redis",
        "datadirectory": "***REMOVED SENSITIVE VALUE***",
        "tempdirectory": "\/tmp",
        "appstoreenabled": true,
        "activity_expire_days": 14,
        "auth.bruteforce.protection.enabled": true,
        "htaccess.RewriteBase": "\/",
        "knowledgebaseenabled": false,
        "logtimezone": "Europe\/Paris",
        "updatechecker": false,
        "upgrade.disable-web": true,
        "overwriteprotocol": "https",
        "quota_include_external_storage": false,
        "trashbin_retention_obligation": "auto, 7",
        "versions_retention_obligation": "auto, 30",
        "updater.release.channel": "stable",
        "default_language": "fr",
        "default_locale": "fr_FR",
        "skeletondirectory": "",
        "default_phone_region": "fr",
        "enabledPreviewProviders": [
            "OC\\Preview\\Imaginary",
            "OC\\Preview\\MarkDown",
            "OC\\Preview\\TXT"
        ],
        "preview_imaginary_url": "***REMOVED SENSITIVE VALUE***",
        "passwordsalt": "***REMOVED SENSITIVE VALUE***",
        "secret": "***REMOVED SENSITIVE VALUE***",
        "trusted_domains": [
            "***REMOVED SENSITIVE VALUE***"
        ],
        "version": "27.1.7.2",
        "overwrite.cli.url": "***REMOVED SENSITIVE VALUE***",
        "overwritehost": "***REMOVED SENSITIVE VALUE***",
        "installed": true,
        "maintenance": false,
        "preview_max_memory": 256,
        "preview_max_x": 1024,
        "preview_max_y": 1024,
        "preview_max_scale_factor": 1,
        "allow_local_remote_servers": false,
        "simpleSignUpLink.shown": false,
        "filelocking.enabled": true,
        "updatedirectory": "\/tmp",
        "loglevel": 3,
        "preview_concurrency_new": 4,
        "maintenance_window_start": 1,
        "bulkupload.enabled": false,
        "has_valid_subscription": true,
        "preview_concurrency_all": 8,
        "memcache.distributed": "\\OC\\Memcache\\Redis",
        "profile.enabled": false,
        "session_relaxed_expiry": true,
        "filelocking.ttl": 600,
        "preview_format": "webp",
        "ldapProviderFactory": "OCA\\User_LDAP\\LDAPProviderFactory"
    }
}

List of activated Apps

# occ app:list
Enabled:
  - activity: 2.19.0
  - approval: 1.1.1
  - bruteforcesettings: 2.7.0
  - circles: 27.0.1
  - cloud_federation_api: 1.10.0
  - comments: 1.17.0
  - contacts: 5.5.2
  - contactsinteraction: 1.8.0
  - dashboard: 7.7.0
  - dav: 1.27.0
  - deck: 1.11.4
  - drawio: 2.1.4
  - external: 5.2.1
  - federatedfilesharing: 1.17.0
  - federation: 1.17.0
  - files: 1.22.0
  - files_mindmap: 0.0.30
  - files_pdfviewer: 2.8.0
  - files_reminders: 1.0.0
  - files_rightclick: 1.6.0
  - files_sharing: 1.19.0
  - files_trashbin: 1.17.0
  - files_versions: 1.20.0
  - groupfolders: 15.3.5
  - impersonate: 1.14.0
  - logreader: 2.12.0
  - lookup_server_connector: 1.15.0
  - notifications: 2.15.0
  - notify_push: 0.6.9
  - oauth2: 1.15.2
  - onlyoffice: 8.2.4
  - openotp_auth: 1.5.1
  - openotp_sign: 1.5.2
  - password_policy: 1.17.0
  - passwords: 2023.12.32
  - privacy: 1.11.0
  - provisioning_api: 1.17.0
  - related_resources: 1.2.0
  - settings: 1.9.0
  - sharebymail: 1.17.0
  - spreed: 17.1.6
  - systemtags: 1.17.0
  - theming: 2.2.0
  - twofactor_backupcodes: 1.16.0
  - user_ldap: 1.17.0
  - user_status: 1.7.0
  - viewer: 2.1.0
  - workflowengine: 2.9.0

Nextcloud Signing status

No errors have been found.

Nextcloud Logs

{
  "reqId": "FfGPeqjikSxzJluVjDKd",
  "level": 3,
  "time": "2024-03-10T12:20:28+01:00",
  "user": "tvi",
  "app": "webdav",
  "method": "PATCH",
  "url": "/remote.php/dav/files/tvi/02%20-%20R%C3%A9f%C3%A9rentiel/00%20-%20Mod%C3%A8les%20et%20ent%C3%AAtes/01%20-%20Logo%20Le%20Pois/Logo-blanccote.png",
  "message": "OC\\Files\\View::hash(): Return value must be of type string|bool, null returned",
  "userAgent": "Mozilla/5.0 (Macintosh) mirall/3.12.1git (build 21208) (Nextcloud, osx-23.3.0 ClientArchitecture: arm64 OsArchitecture: arm64)",
  "version": "27.1.7.2",
  "exception": {
    "Exception": "TypeError",
    "Message": "OC\\Files\\View::hash(): Return value must be of type string|bool, null returned",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/File.php",
        "line": 779,
        "function": "hash",
        "class": "OC\\Files\\View",
        "type": "->",
        "args": [
          "sha1",
          "/02 - Référentiel/00 - Modèles et entêtes/01 - Logo Le Pois/Logo-blanccote.png"
        ]
      },
      {
        "file": "/var/www/nextcloud/apps/dav/lib/Connector/Sabre/ChecksumUpdatePlugin.php",
        "line": 71,
        "function": "hash",
        "class": "OCA\\DAV\\Connector\\Sabre\\File",
        "type": "->",
        "args": [
          "sha1"
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "httpPatch",
        "class": "OCA\\DAV\\Connector\\Sabre\\ChecksumUpdatePlugin",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 472,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "method:PATCH",
          [
            [
              "Sabre\\HTTP\\Request"
            ],
            [
              "Sabre\\HTTP\\Response"
            ]
          ]
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 253,
        "function": "invokeMethod",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 321,
        "function": "start",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/nextcloud/apps/dav/lib/Server.php",
        "line": 368,
        "function": "exec",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php",
        "line": 35,
        "function": "exec",
        "class": "OCA\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/nextcloud/remote.php",
        "line": 172,
        "args": [
          "/var/www/nextcloud/apps/dav/appinfo/v2/remote.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/nextcloud/lib/private/Files/View.php",
    "Line": 1097,
    "message": "OC\\Files\\View::hash(): Return value must be of type string|bool, null returned",
    "exception": [],
    "CustomMessage": "OC\\Files\\View::hash(): Return value must be of type string|bool, null returned"
  },
  "id": "65edb13d061a6"
}

Additional info

No response

keomabrun · 2024-03-12T14:17:10Z

It might be just a coincidence but I started seeing those errors as well this morning, right after enabling memcache.distributed with Redis.

To match https://github.com/nextcloud/server/blob/beececf66068f57c416225efcde9b44ce5c2e835/lib/private/Files/View.php#L1050 - Fix #44110 Signed-off-by: Louis Chemineau <louis@chmn.me>

keomabrun · 2024-07-29T09:41:46Z

Hi 👋

I updated to v28.0.8 and I still have that error in the logs. Let me know if you need more info to debug/diag this issue 🙏

Thanks for the work !

solracsf · 2024-07-29T15:47:03Z

Feel free to try this PR: https://github.com/nextcloud/server/pull/46845/files

To match https://github.com/nextcloud/server/blob/beececf66068f57c416225efcde9b44ce5c2e835/lib/private/Files/View.php#L1050 - Fix #44110 Signed-off-by: Louis Chemineau <louis@chmn.me>

solracsf added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap 27-feedback labels Mar 10, 2024

artonge mentioned this issue Jul 1, 2024

Ensure that the hash method does not return null #46218

Merged

solracsf mentioned this issue Jul 29, 2024

fix(files): Don't try to hash invalid paths #46845

Closed

4 tasks

joshtrichards added feature: filesystem 3. to review Waiting for reviews and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Aug 1, 2024

skjnldsv closed this as completed in #46218 Sep 16, 2024

skjnldsv closed this as completed in 6674f79 Sep 16, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug]: `\OC\Files\View::hash()`: Return value must be of type `string|bool`, `null` returned #44110

[Bug]: `\OC\Files\View::hash()`: Return value must be of type `string|bool`, `null` returned #44110

solracsf commented Mar 10, 2024 •

edited

Loading

keomabrun commented Mar 12, 2024

keomabrun commented Jul 29, 2024

solracsf commented Jul 29, 2024

[Bug]: \OC\Files\View::hash(): Return value must be of type string|bool, null returned #44110

[Bug]: \OC\Files\View::hash(): Return value must be of type string|bool, null returned #44110

Comments

solracsf commented Mar 10, 2024 • edited Loading

⚠️ This issue respects the following points: ⚠️

Bug description

Steps to reproduce

Expected behavior

Installation method

Nextcloud Server version

Operating system

PHP engine version

Web server

Database engine version

Is this bug present after an update or on a fresh install?

Are you using the Nextcloud Server Encryption module?

What user-backends are you using?

Configuration report

List of activated Apps

Nextcloud Signing status

Nextcloud Logs

Additional info

keomabrun commented Mar 12, 2024

keomabrun commented Jul 29, 2024

solracsf commented Jul 29, 2024

[Bug]: `\OC\Files\View::hash()`: Return value must be of type `string|bool`, `null` returned #44110

[Bug]: `\OC\Files\View::hash()`: Return value must be of type `string|bool`, `null` returned #44110

solracsf commented Mar 10, 2024 •

edited

Loading