Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill \OC_App::installApp #4453

Closed
LukasReschke opened this issue Apr 23, 2017 · 1 comment · Fixed by #4867
Closed

Kill \OC_App::installApp #4453

LukasReschke opened this issue Apr 23, 2017 · 1 comment · Fixed by #4867
Labels
3. to review Waiting for reviews bug
Milestone
Nextcloud 12.0

Comments

@LukasReschke
Copy link
Member

\OC_App::installApp is a duplicate of \OC\Installer::installApp which wouldn't be a problem if the code however wouldn't be different…

So the OC_App method is for example setting up the settings sidebar while the OC\Installer one is not. The OC_App one should simply invoke the \OC\Installer.
@LukasReschke LukasReschke added this to the Nextcloud 12.0 milestone Apr 23, 2017
@LukasReschke LukasReschke mentioned this issue Apr 23, 2017
Merged
5 tasks
MorrisJobke added a commit that referenced this issue May 15, 2017
@MorrisJobke
Remove OC_App:installApp
be33234 
* uses Installer->installApp now
* removes unused code
* fixes #4453
* added some additional checks

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label May 15, 2017
@MorrisJobke MorrisJobke mentioned this issue May 15, 2017
Merged
@MorrisJobke
Copy link
Member

Fix is in #4867

@MorrisJobke MorrisJobke mentioned this issue Feb 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging a pull request may close this issue.

Remove OC_App:installApp nextcloud/server
2 participants
@MorrisJobke @LukasReschke