Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NC30 UI refresh cleanup #46016

Closed
28 tasks done
marcoambrosini opened this issue Jun 20, 2024 · 26 comments
Closed
28 tasks done

NC30 UI refresh cleanup #46016

marcoambrosini opened this issue Jun 20, 2024 · 26 comments
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug design Design, UI, UX, etc.

Comments

@marcoambrosini
Copy link
Member

marcoambrosini commented Jun 20, 2024

Vue library

Draft nextcloud-libraries/nextcloud-vue#5746

Server

Dashboard

Updater & AIO

cc @jancborchardt @nimishavijay @susnux @ShGKme @skjnldsv

@marcoambrosini marcoambrosini added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jun 20, 2024
@marcoambrosini marcoambrosini moved this to 📐 At design in 🖍 Design team Jun 20, 2024
@marcoambrosini marcoambrosini changed the title NC30 Design changes cleanup NC30 UI refresh cleanup Jun 20, 2024
@come-nc

This comment was marked as resolved.

@marcoambrosini

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@hamza221

This comment was marked as resolved.

@marcoambrosini marcoambrosini self-assigned this Jul 4, 2024
@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of bug and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement labels Jul 9, 2024
@szaimen szaimen added design Design, UI, UX, etc. enhancement and removed bug labels Jul 9, 2024
@jancborchardt jancborchardt moved this from 📐 At design to 👓 Design review in 🖍 Design team Jul 9, 2024
@ChristophWurst

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

  • HTML inputs have a 2px border radius, not var(--border-width-input, 2px) that is used in NcSelect. This creates inconsistency

border: 2px solid var(--color-border-maxcontrast);

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@marcoambrosini
Copy link
Member Author

@susnux @ShGKme @GVodyanov please update the checkboxes if you fix some of those things

@susnux

This comment was marked as resolved.

@skjnldsv
Copy link
Member

skjnldsv commented Jul 31, 2024

image

  • Quota is looking weird

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

  • Contacts menu handle scrolls on mobile
Bildschirmaufzeichnung.vom.2024-08-06.07-44-57.webm

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

NcDateTimePicker height is too big

The picker needs a general design update for 30: nextcloud-libraries/nextcloud-vue#5951

@ChristophWurst

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

  • Main menu at the top right doesn't look very compact and there is too much space between the action icon and text

image

@susnux
Copy link
Contributor

susnux commented Aug 19, 2024

Main menu at the top right doesn't look very compact and there is too much space between the action icon and text

This is the compact styling of NcListItem, best we can do here is removing 4px padding from the inner wrapper, allowing a total size of 38px (height) (34px content + 2*2px focus visible outline). (currently one item is 42px height)

@ChristophWurst

This comment was marked as resolved.

@jancborchardt

This comment was marked as resolved.

@ChristophWurst
Copy link
Member

  • Unfocused text inputs have a 2px border

border: 2px solid var(--color-border-maxcontrast);

This shows in apps too, like Mail

image

@susnux
Copy link
Contributor

susnux commented Aug 29, 2024

@ChristophWurst

This shows in apps too, like Mail

I strongly recommend to use NcInputField for this:

https://github.com/nextcloud/mail/blob/62f1cec233ab92a311bcb0f70967d49f64bd1d8d/src/components/SearchMessages.vue#L8-L13

@ChristophWurst
Copy link
Member

Yep, agree. But vanilla inputs should also have the correct style.

@marcoambrosini
Copy link
Member Author

Closing, moved few remaining things in new issues

@github-project-automation github-project-automation bot moved this from 👓 Design review to 🎉 Done in 🖍 Design team Sep 4, 2024
@jancborchardt
Copy link
Member

Great job everyone and especially @marcoambrosini for driving this. We came out with a really much more refined interface. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 30-feedback bug design Design, UI, UX, etc.
Projects
Archived in project
Development

No branches or pull requests

8 participants