Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(styles): Guest layout should follow the new design #47152

Merged
merged 2 commits into from
Aug 9, 2024
Merged

fix(styles): Guest layout should follow the new design #47152

merged 2 commits into from
Aug 9, 2024

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Aug 9, 2024 •
edited
Loading

Summary

  1. Adjust some places that used the old pill-style design
  2. Make indention consistent using tabs
  3. Remove duplicates styles for inputs (also included in server.css) that conflict with nextcloud-vue styles

Screenshots

before after
Bildschirmfoto_20240809_133659 Bildschirmfoto_20240809_134543
Bildschirmfoto_20240809_134505 Bildschirmfoto_20240809_134448

Checklist

@susnux
fix(styles): Guest layout should follow the new design
874de85 
1. Adjust some places that used the old pill-style design
2. Make indention consistent using tabs
3. Remove duplicates styles for inputs (also included in server.css) that conflic with nextcloud-vue styles

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux
chore: Compile assets
2d99539 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux marked this pull request as ready for review August 9, 2024 13:03
@susnux susnux added bug design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 9, 2024
@susnux susnux added this to the Nextcloud 30 milestone Aug 9, 2024
@susnux susnux mentioned this pull request Aug 9, 2024
Closed
28 tasks
st3iny
st3iny approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Looks much better now!

ChristophWurst
ChristophWurst approved these changes Aug 9, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@susnux susnux merged commit 9074235 into master Aug 9, 2024
115 checks passed
@susnux susnux deleted the fix/guest-layout branch August 9, 2024 18:15
@skjnldsv skjnldsv mentioned this pull request Aug 13, 2024
Merged
@susnux susnux mentioned this pull request Sep 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st3iny st3iny st3iny approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@marcoambrosini marcoambrosini Awaiting requested review from marcoambrosini

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

[Bug]: Misaligned username/password placeholders on login page
3 participants
@susnux @ChristophWurst @st3iny