Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File template rework #46455

Open
juliusknorr opened this issue Jul 11, 2024 · 6 comments
Open

File template rework #46455

juliusknorr opened this issue Jul 11, 2024 · 6 comments
Assignees
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: templates

Comments

@juliusknorr
Copy link
Member

Our current ways to manage, organize and distribute file templates is a wild mix of old code and not very accessible to admins and end users.

The server provides the possibility for a user defined directory but there is no option to change it or see which folder that is.

Screenshot 2024-07-11 at 17 50 23

Additionally templates that we ship are only copied on user creation, so existing users will not get updated or new templates.

Collabora has additionally a separate config option for a user template directory and an admin Ui where admins can define instance wide templates:

Screenshot 2024-07-11 at 17 51 18 Screenshot 2024-07-11 at 17 50 55

Especially in larger organizations, defining and updating templates on the admin level is quite important, but also for us shipping new templates regularly this would be better way as currently those templates only reach new users.

My proposal to clean this up would be:

  • Add a folder picker to the files settings modal so users can have a fixed way to set, update which folder is used as their personal template directory
  • Add a special icon to show for the folder that is the current user template directory
  • Add an admin settings section where admins can upload and manage template files that are exposed to all users in the template picker dialog
  • Remove the Collabora settings as they get obsolete with the server ones
  • That way other apps like text can also make use of this

Open questions:

  • Should users be able to opt out of admin defined templates?
  • How do we want to handle our default templates?
    • It probably makes sense to add them as system wide templates
    • However then users cannot adjust them on their own unless there is an opt out
    • Admins might still want to remove them, maybe it is the best to just have a checkbox to include shipped templates or not?

@nextcloud/designers for feedback

FYI @sorbaugh as it touches the area of files

@juliusknorr juliusknorr added enhancement 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 11, 2024
@github-project-automation github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Office team Jul 11, 2024
@jancborchardt jancborchardt moved this to 🧭 Planning evaluation / ideas in 🖍 Design team Jul 25, 2024
@juliusknorr
Copy link
Member Author

To be evaluated additonally:

  • Templates per groupfolder/team/group
  • Templates in Collectives could use the same mechanism
  • Delegating template management

@juliusknorr
Copy link
Member Author

From discussion with @jancborchardt

  • User template folder
    • Move setting to files for updating the location
    • No longer copy skeleton files, auto create templates folder but empty
    • Mark templates folder with icon
    • Give hint about what the template folder is (maybe with button to view admin templates)
  • Template management for admins
    • Move from richdocuments to files
    • Put shipped template files as admin templates
  • Admins can disable user templates
  • Group limiting for individual tempaltes in admin interface
    • To be clarified if sections for each group or maybe just an option to disable templates for specific groups

Templates per team/group

Would be covered by the above

Delegating template management

Can be handled by admin delegation

Template per groupfolder
Templates in Collectives could use the same mechanism

Could be done by an extra Templates folder for each collective/groupfolder but as a next step.

@jancborchardt jancborchardt moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team Oct 17, 2024
@jancborchardt
Copy link
Member

Just talked about this a bit with @nimishavijay and there are 2 specific issues we came across:

  • Possibly big issue: With only having the templates in settings and not in a folder, they would not be synced to desktop. How can people create files using templates there?
  • Less important: A lot of templates are folder-specific like e.g. invoices which are in one folder, or reimbursements which are in another. It’s a bit similar to team/group specific templates, but maybe a bit overkill to limit it like that.

@joshtrichards
Copy link
Member

joshtrichards commented Nov 23, 2024

Good stuff! Sounds like this work will effectively cover #38198 and #25358 (including most of the follow-on comments therein).

Possibly big issue: With only having the templates in settings and not in a folder, they would not be synced to desktop. How can people create files using templates there?

User-level templates would still be derived from a user owned/controlled folder in the proposed design. At the admin-level, they'd manage (upload/etc) templates via Admin settings. And users don't need to be able to edit the system provided templates.

Less important: A lot of templates are folder-specific like e.g. invoices which are in one folder, or reimbursements which are in another. It’s a bit similar to team/group specific templates, but maybe a bit overkill to limit it like that.

I'm not sure how we'd handle folder specific templates, unless we started classifying folders... Wait, maybe we could associate templates with certain tags?... That would create the affiliation desired. Then the New button would activate for templates tagged the same as the folder the user is in.

@joshtrichards
Copy link
Member

User template folder: No longer copy skeleton files, auto create templates folder but empty

Can maybe take care of the #31414 transition at the same time we touch the user template folder settings.

@jancborchardt
Copy link
Member

Possibly big issue: With only having the templates in settings and not in a folder, they would not be synced to desktop. How can people create files using templates there?

FYI @juliusknorr this concern of @nimishavijay and me was also seconded by @karlitschek and @schiessle – so having this as a folder which can be synced is a requirement.

For this we need to keep in mind that the "Templates" folder name needs to be localized depending on language, which doesn’t work with a regular shared folder.

pboguslawski added a commit to ibpl/server that referenced this issue Jan 16, 2025
…nfiguration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: nextcloud#39266
Related: nextcloud#46455
Author-Change-Id: IB#1156403
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
AndyScherzinger pushed a commit that referenced this issue Jan 27, 2025
…nfiguration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
AndyScherzinger pushed a commit that referenced this issue Jan 27, 2025
…nfiguration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403
Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 27, 2025
…in configuration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403

Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 27, 2025
…in configuration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403

Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger pushed a commit that referenced this issue Jan 27, 2025
…in configuration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403

Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
backportbot bot pushed a commit that referenced this issue Jan 27, 2025
…in configuration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403

Signed-off-by: Pawel Boguslawski <pawel.boguslawski@ib.pl>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@juliusknorr juliusknorr moved this from 📄 To do (~10 entries) to 🧭 Planning evaluation (don't pick) in 📝 Office team Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap enhancement feature: templates
Projects
Status: 🧭 Planning evaluation (don't pick)
Status: 🏗️ At engineering
Development

No branches or pull requests

5 participants