Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically set maxApps display #5121

Closed
patschi opened this issue May 26, 2017 · 2 comments
Closed

Dynamically set maxApps display #5121

patschi opened this issue May 26, 2017 · 2 comments
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement
Milestone

Comments

@patschi
Copy link
Member

patschi commented May 26, 2017

Idea would be basically to be able to set the amount of apps to be shown by default in the headers. Currently only 8 apps are going to be displayed, more apps will be displayed in the "More apps" dropdown.

Everything seems to be handled dynamically via JS already, just var maxApps = 8; variable in /core/js/js.js#L1514 needs to be defined over PHP.

@wwwindisch
Copy link

Does a higher default value cause any negative side effects? I've set it to var maxApps = 32; and everything seems to work as expected:
All of my activated apps (currently 14) are shown in fullscreen mode in the top bar. When I resize the browser window, they get automatically grouped into the "More apps" dropdown.

What I mean: Is it even necessary to define maxApps over PHP? Or would a higher default value (as a quick, straight forward solution) solve the issue as well?

@juliusknorr
Copy link
Member

@jancborchardt @nextcloud/designers any opinion on that? For me it would also make sense to just remove the maximum apps limit, since we reduce the showed apps depending on the screen space already.

@juliusknorr juliusknorr added 0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement labels May 26, 2017
@MorrisJobke MorrisJobke added this to the Nextcloud 13 milestone May 31, 2017
juliusknorr pushed a commit that referenced this issue May 31, 2017
Signed-off-by: Patrik Kernstock <info@pkern.at>
juliusknorr pushed a commit that referenced this issue Jun 15, 2017
Signed-off-by: Patrik Kernstock <info@pkern.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage Pending check for reproducibility or if it fits our roadmap design Design, UI, UX, etc. enhancement
Projects
None yet
Development

No branches or pull requests

4 participants