Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore a file from trashbin -> Undefined index: files at cloud/apps/files_trashbin/ajax/undelete.php#31 #528

Closed
Dennis1993 opened this issue Jul 22, 2016 · 3 comments · Fixed by #547

Comments

@Dennis1993
Copy link
Contributor

Steps to reproduce

  1. delete a file
  2. restore it from trashbin

Actual behaviour

Tell us what happens instead
file is restored but error message in log

Server configuration

Operating system:
Ubuntu

Web server:
Apache 2.4

Database:
MySQL 5.6.

PHP version:
7.0.8

Nextcloud version: (see Nextcloud admin page)
9.0.53 (stable)

Updated from an older Nextcloud/ownCloud or fresh install:
fresh install

Where did you install Nextcloud from:
nextcloud.com

List of activated apps:

Default apps with calendar app

The content of config/config.php:

default

Are you using external storage, if yes which one: local/smb/sftp/...
no

Are you using encryption: yes/no
no

Are you using an external user-backend, if yes which one: LDAP/ActiveDirectory/Webdav/...
no

Client configuration

Browser:
IE11, Microsoft Edge

Operating system:
Windows 10

Logs

Web server error log

Web server error log

Undefined index: files at cloud/apps/files_trashbin/ajax/undelete.php#31
@LukasReschke LukasReschke added bug 0. Needs triage Pending check for reproducibility or if it fits our roadmap feature: trashbin labels Jul 22, 2016
@LukasReschke LukasReschke self-assigned this Jul 22, 2016
@LukasReschke
Copy link
Member

LukasReschke commented Jul 22, 2016

While I can see in the code what triggers this error message I can't quite understand when this code path is triggered.

Does this happen for any file? Or are they in subfolders or do you try to restore folders? Would be awesome if I would be able to reproduce this locally.

@Dennis1993
Copy link
Contributor Author

Dennis1993 commented Jul 22, 2016

I know whats the Problem or how you can reproduce it.

I have deleted a file (picture) from the root. If I click on "Wiederherstellen" (restore file) in the same line behind the file Name -> no error occurs.
But if I select the file and use the button above the table -> error is logged.

Here a screenshot with a Little documentation what I've do.

Thanks for your reply!

restore_error

MorrisJobke added a commit that referenced this issue Jul 25, 2016
* use $_POST['files'] only of ssinlge files are restored
* fixes #528
@MorrisJobke
Copy link
Member

Fix is in #547

@MorrisJobke MorrisJobke removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap needs info labels Jul 25, 2016
@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Jul 25, 2016
MorrisJobke added a commit that referenced this issue Jul 25, 2016
* use $_POST['files'] only of ssinlge files are restored
* fixes #528
MorrisJobke added a commit that referenced this issue Jul 25, 2016
* use $_POST['files'] only of ssinlge files are restored
* fixes #528
@MorrisJobke MorrisJobke removed their assignment Sep 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants