dav: default contact access polutes debug logs

[susnux]

Originally posted by @come-nc in #53568 (comment)

The logs of CI for integration are polluted with the following.
Most likely the default contact is accessed before being created or something like that.

{
  "Exception": "OCP\\Files\\NotFoundException",
  "Message": "/appdata_oc2crh70w5hw/dav/defaultContact",
  "Code": 0,
  "Trace": [
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/LazyFolder.php",
      "line": 138,
      "function": "get",
      "class": "OC\\Files\\Node\\Root",
      "type": "->",
      "args": [
        "/appdata_oc2crh70w5hw/dav/defaultContact"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/Files/AppData/AppData.php",
      "line": 114,
      "function": "get",
      "class": "OC\\Files\\Node\\LazyFolder",
      "type": "->",
      "args": [
        "appdata_oc2crh70w5hw/dav/defaultContact"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/apps/dav/lib/Service/ExampleContactService.php",
      "line": 93,
      "function": "getFolder",
      "class": "OC\\Files\\AppData\\AppData",
      "type": "->",
      "args": [
        "defaultContact"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/apps/dav/lib/Listener/UserEventsListener.php",
      "line": 183,
      "function": "createDefaultContact",
      "class": "OCA\\DAV\\Service\\ExampleContactService",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/apps/dav/lib/Listener/UserEventsListener.php",
      "line": 77,
      "function": "firstLogin",
      "class": "OCA\\DAV\\Listener\\UserEventsListener",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/ServiceEventListener.php",
      "line": 57,
      "function": "handle",
      "class": "OCA\\DAV\\Listener\\UserEventsListener",
      "type": "->",
      "args": [
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        }
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
      "line": 220,
      "function": "__invoke",
      "class": "OC\\EventDispatcher\\ServiceEventListener",
      "type": "->",
      "args": [
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        },
        "OCP\\User\\Events\\UserFirstTimeLoggedInEvent",
        {
          "__class__": "Symfony\\Component\\EventDispatcher\\EventDispatcher"
        }
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/3rdparty/symfony/event-dispatcher/EventDispatcher.php",
      "line": 56,
      "function": "callListeners",
      "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
      "type": "->",
      "args": [
        [
          {
            "__class__": "Closure"
          }
        ],
        "OCP\\User\\Events\\UserFirstTimeLoggedInEvent",
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        }
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php",
      "line": 67,
      "function": "dispatch",
      "class": "Symfony\\Component\\EventDispatcher\\EventDispatcher",
      "type": "->",
      "args": [
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        },
        "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/EventDispatcher/EventDispatcher.php",
      "line": 79,
      "function": "dispatch",
      "class": "OC\\EventDispatcher\\EventDispatcher",
      "type": "->",
      "args": [
        "OCP\\User\\Events\\UserFirstTimeLoggedInEvent",
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        }
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 529,
      "function": "dispatchTyped",
      "class": "OC\\EventDispatcher\\EventDispatcher",
      "type": "->",
      "args": [
        {
          "__class__": "OCP\\User\\Events\\UserFirstTimeLoggedInEvent"
        }
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 358,
      "function": "prepareUserLogin",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        true,
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 586,
      "function": "completeLogin",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 308,
      "function": "loginWithPassword",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 406,
      "function": "login",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/private/User/Session.php",
      "line": 545,
      "function": "logClientIn",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/lib/base.php",
      "line": 1125,
      "function": "tryBasicAuthLogin",
      "class": "OC\\User\\Session",
      "type": "->",
      "args": [
        "*** sensitive parameters replaced ***",
        "*** sensitive parameters replaced ***"
      ]
    },
    {
      "file": "/home/runner/actions-runner/_work/server/server/ocs/v1.php",
      "line": 58,
      "function": "handleLogin",
      "class": "OC",
      "type": "::",
      "args": [
        "*** sensitive parameters replaced ***"
      ]
    }
  ],
  "File": "/home/runner/actions-runner/_work/server/server/lib/private/Files/Node/Root.php",
  "Line": 182,
  "message": "Couldn't get default contact file",
  "exception": {},
  "CustomMessage": "Couldn't get default contact file"
}

[st3iny]

This is a regression from my PR.

server/apps/dav/lib/Service/ExampleContactService.php

Lines 87 to 99 in 960b3ec

	public function createDefaultContact(int $addressBookId): void {
	if (!$this->isDefaultContactEnabled()) {
	return;
	}
	try {
	$folder = $this->appData->getFolder('defaultContact');
	$defaultContactFile = $folder->getFile('defaultContact.vcf');
	$data = $defaultContactFile->getContent();
	} catch (\Exception $e) {
	$this->logger->error('Couldn\'t get default contact file', ['exception' => $e]);
	return;
	}

The default value for the feature is enabled now and thus the contact is tried to be created all the time now.

See also #52494

[hamza221]

This is a regression from my PR.

server/apps/dav/lib/Service/ExampleContactService.php

Lines 87 to 99 in 960b3ec

public function createDefaultContact(int $addressBookId): void {
if (!$this->isDefaultContactEnabled()) {
return;
}

try {
$folder = $this->appData->getFolder('defaultContact');
$defaultContactFile = $folder->getFile('defaultContact.vcf');
$data = $defaultContactFile->getContent();
} catch (\Exception $e) {
$this->logger->error('Couldn't get default contact file', ['exception' => $e]);
return;
}
The default value for the feature is enabled now and thus the contact is tried to be created all the time now.

See also #52494

I'll create the default .vcf file on addressbook created event in a pr later today