Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expiry date calendar for shares is misplaced #7007

Closed
MorrisJobke opened this issue Oct 30, 2017 · 8 comments
Closed

Expiry date calendar for shares is misplaced #7007

MorrisJobke opened this issue Oct 30, 2017 · 8 comments

Comments

@MorrisJobke
Copy link
Member

  • create a share
  • open the menu of that share
  • activate the expiry date
  • actual: calendar widget is misplaced
  • expected: calendar widget is positioned correctly

bildschirmfoto 2017-10-30 um 09 32 02

It is also unrelated to #6976 because it was broken before

cc @nextcloud/javascript @skjnldsv @jancborchardt

@jancborchardt
Copy link
Member

Also there is way too much whitespace in the popover. Should be a date input field below the option only, and the datepicker originating from there.

@skjnldsv
Copy link
Member

@MorrisJobke Damn, I was sure I fixed this in a pr somewhere! :O
It's related to 82a52a8#commitcomment-25212534

@MorrisJobke
Copy link
Member Author

@nextcloud/designers This is still an issue 😢

@skjnldsv skjnldsv self-assigned this Dec 12, 2017
@jancborchardt
Copy link
Member

Also cc @pixelipo since he worked on the datepicker :)

@juliusknorr
Copy link
Member

The positioning is also wrong if the remaining space under the input field is not big enough for the datepicker: Issue in deck nextcloud/deck#365 but it also occurs in files

@pixelipo
Copy link
Contributor

@juliushaertl I'm not really sure that that is a bug - it happens only when there is not enough screen space to render the popover. If it didn't do that, then the calendar would be partially hidden and thus unusable. I agree that it doesn't look great but utility is more important than aesthetics...

@pixelipo
Copy link
Contributor

pixelipo commented Dec 21, 2017

@MorrisJobke regarding the original bug this issue is about, I created a work-in-progress PR that should solve it: #7595

EDIT: nevermind, that PR is basically a duplicate of #7477 - which will solve this bug

@MorrisJobke
Copy link
Member Author

Fix for this is in #7477

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants