-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expiry date calendar for shares is misplaced #7007
Comments
Also there is way too much whitespace in the popover. Should be a date input field below the option only, and the datepicker originating from there. |
@MorrisJobke Damn, I was sure I fixed this in a pr somewhere! :O |
@nextcloud/designers This is still an issue 😢 |
Also cc @pixelipo since he worked on the datepicker :) |
The positioning is also wrong if the remaining space under the input field is not big enough for the datepicker: Issue in deck nextcloud/deck#365 but it also occurs in files |
@juliushaertl I'm not really sure that that is a bug - it happens only when there is not enough screen space to render the popover. If it didn't do that, then the calendar would be partially hidden and thus unusable. I agree that it doesn't look great but utility is more important than aesthetics... |
@MorrisJobke regarding the original bug this issue is about, I created a work-in-progress PR that should solve it: #7595 EDIT: nevermind, that PR is basically a duplicate of #7477 - which will solve this bug |
Fix for this is in #7477 |
It is also unrelated to #6976 because it was broken before
cc @nextcloud/javascript @skjnldsv @jancborchardt
The text was updated successfully, but these errors were encountered: