Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom share expiry date datepicker location #7595

Closed
wants to merge 1 commit into from

Conversation

pixelipo
Copy link
Contributor

Fixes #7007

This is still a work-in-progress. I have changed the left to a magical 44px that seems to do the trick for this particular problem (without causing a break anywhere else).

I've also disabled hiding the datepicker input field when datepicker calendar is shown, because that didn't seem right. The problem is, now it shows "Invalid date" - instead, it should probably just show default "placeholder" (which is not set for this field).

TODO:

  • remove "Invalid date" input value
  • add a default placeholder to the input
  • make sure datepicker popover doesn't change parent popover's width

I could use some help and/or advice, @nextcloud/designers @nextcloud/javascript

Signed-off-by: Marin Treselj <marin@pixelipo.com>
@pixelipo pixelipo added the 2. developing Work in progress label Dec 21, 2017
@pixelipo pixelipo self-assigned this Dec 21, 2017
@pixelipo
Copy link
Contributor Author

I have also noticed that the "global" file share link expiry datepicker DOM is not created where it should be (inside the .expirationView.subView object), and has to be placed dinamically. Is that desired behaviour? See screenshot for more information:
image

@pixelipo
Copy link
Contributor Author

Ok, it's been a hard week - this PR is a duplicate of @skjnldsv 's #7477 - closing, we'll make sure the other one is good enough to merge...

@pixelipo pixelipo closed this Dec 21, 2017
@pixelipo pixelipo removed the 2. developing Work in progress label Dec 21, 2017
@MorrisJobke MorrisJobke deleted the sharing-datepicker-position branch December 21, 2017 14:01
@pixelipo pixelipo removed their assignment Dec 21, 2017
@jancborchardt
Copy link
Member

@pixelipo ❤️ take some time to relax then! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants