Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13] Improved logging of smb connection errors #10093

Merged
merged 1 commit into from
Jul 3, 2018

Conversation

icewind1991
Copy link
Member

Backport of #10090

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Jul 3, 2018
@icewind1991 icewind1991 added this to the Nextcloud 13.0.5 milestone Jul 3, 2018
@codecov
Copy link

codecov bot commented Jul 3, 2018

Codecov Report

Merging #10093 into stable13 will decrease coverage by <.01%.
The diff coverage is 0%.

@@              Coverage Diff               @@
##             stable13   #10093      +/-   ##
==============================================
- Coverage       51.43%   51.43%   -0.01%     
  Complexity      25138    25138              
==============================================
  Files            1613     1613              
  Lines           95632    95640       +8     
  Branches         1376     1376              
==============================================
+ Hits            49186    49188       +2     
- Misses          46446    46452       +6
Impacted Files Coverage Δ Complexity Δ
apps/dav/lib/Connector/Sabre/ObjectTree.php 56.97% <0%> (ø) 34 <0> (ø) ⬇️
apps/files_external/lib/Lib/Storage/SMB.php 5.24% <0%> (-0.16%) 121 <0> (ø)
apps/files_trashbin/lib/Trashbin.php 72.53% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke merged commit f5bbe21 into stable13 Jul 3, 2018
@MorrisJobke MorrisJobke deleted the smb-log-connection-errors-13 branch July 3, 2018 21:06
@MorrisJobke MorrisJobke mentioned this pull request Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants