Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow automatic DI for the View #1038

Closed
wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the annotation information on this pull request, we identified @BernhardPosselt, @DeepDiver1975 and @rullzer to be potential reviewers

@rullzer
Copy link
Member

rullzer commented Aug 24, 2016

I still think we should use the Node API more. But admittedly this is not possible everywhere.

I had the discussion a bit with @BernhardPosselt where we do the DI of private classes. Still need to think about that a bit more and write it down somewhere.

@nickvergessen
Copy link
Member Author

Well people use the view today, this here is just a matter of automating it...

@rullzer
Copy link
Member

rullzer commented Aug 26, 2016

Yeah but it is also currently working. Adding this kind of legitimises the use of the view for Apps. Which is not really true. Apps should only use stuff from OCP

@LukasReschke
Copy link
Member

I do second @rullzer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants