Fix design of update error page #10485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
design
jancborchardt
requested review from
rullzer,
juliushaertl,
kevgathuku and
skjnldsv
skjnldsv
reviewed
Aug 1, 2018
core/css/guest.css
Outdated
| @@ -630,6 +631,9 @@ p.info { | |||
| margin: 10px; | |||
| background-size: 32px; | |||
| } | |||
| #update-progress-icon.icon-error-white { | |||
| background-image: url('data:image/svg+xml;utf8,<svg xmlns="http://www.w3.org/2000/svg" version="1.1" viewbox="0 0 16 16" width="16" height="16"><path d="M5.516 2L2 5.516v4.968L5.516 14h4.968L14 10.484V5.516L10.484 2H5.516zM7 4h2v5H7V4zm0 6h2v2H7v-2z" fill="%23fff"/></svg>'); | |||
There was a problem hiding this comment.
I've restored the white icon file in #10459 so you can use that
There was a problem hiding this comment.
Ok, so I will restore the white error icon too.
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
rullzer
approved these changes
Aug 1, 2018
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@juliushaertl @skjnldsv fixed your remark, please review again. :) |
skjnldsv
approved these changes
Aug 3, 2018
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
juliushaertl
approved these changes
Aug 3, 2018
juliushaertl
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before & after:
Please review @nextcloud/designers