fix internal links in security & setup warnings, resolves #1048 #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@blizzz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @LukasReschke, @rullzer and @PVince81 to be potential reviewers |
|
👍 works although I think we should just link to the docs directly instead of redirecting to a list of links where the user then has to find the one link that matters for them |
|
👍 |
blizzz
added a commit
that referenced
this pull request
Aug 25, 2016
fix internal links in security & setup warnings, resolves #1048 adjust js tests
LukasReschke
added a commit
that referenced
this pull request
Aug 26, 2016
Backport of fix internal links in security & setup warnings #1050
|
@blizzz Please remove the "backport-request" label once the backport PR is opened. Makes it easier to spot not yet backported PRs ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jospoortvliet @LukasReschke @nickvergessen
Fix #1048
small regressions within Admin page, should be backport to Nc 10.