Reduce the number of cache operations for dav operations #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -124,6 +125,9 @@ protected function setUp() { | |||
| call_user_func([$this, $methodName]); | |||
| } | |||
| } | |||
|
|
|||
|
|
|||
| \OC::$server->getRootFolder()->clearCache(); | |||
There was a problem hiding this comment.
This causes a setupFS() on each test case, even when the test doesn't even use anything from the file system. Shouldn't the call in OC_Util::tearDownFS() be enough?
icewind1991
force-pushed
the
less-cache-hits
branch
from
512fe1c to
fb88d66
Compare
|
Nice catch. I doesn't read very easy currently. but that is mainy because of the rest of the code around it. 👍 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces the number of cache operations done for the most basic (and common) dav operation (propfind with depth:0 on the root) from 7 to 2