Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix quickaccess active indicator for folders with spaces #10626

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

juliushaertl
Copy link
Member

Fixes a javascript error and missing active indicator on favorite folders with spaces:

Syntax error, unrecognized expression: li[data-id=-folder with spaces]

Steps to reproduce:

  1. Create a folder named "test with spaces"
  2. Add the folder to the favorites
  3. Unfold the favorites entry in the left navigation
  4. Click the "test with spaces" entry

From https://sentry.rullzer.com/sentry/nextcloud/issues/34

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@rullzer rullzer merged commit 7dc4fad into master Aug 9, 2018
@rullzer rullzer deleted the bugfix/noid/quickaccess-spaces branch August 9, 2018 17:44
@rullzer rullzer mentioned this pull request Aug 9, 2018
45 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants