Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix password enforce on public links #10695

Merged
merged 2 commits into from
Aug 16, 2018
Merged

Fix password enforce on public links #10695

merged 2 commits into from
Aug 16, 2018

Conversation

skjnldsv
Copy link
Member

Fix #10644

@skjnldsv
Fix password enforce on public links
b9c448d 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Aug 15, 2018
@skjnldsv skjnldsv self-assigned this Aug 15, 2018
@juliusknorr
Copy link
Member

juliusknorr commented Aug 15, 2018 •
edited by skjnldsv
Loading

Great @skjnldsv 👍

Two minor bugs I've found during testing:

  • Popover seems to be a bit out of place
    image

  • Ideally we would disable the checkbox for expiration date, when it is enforced
    image

@skjnldsv
Copy link
Member Author

@juliushaertl you're right! Nice catch!
I'll look into it !

@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 15, 2018
@skjnldsv
Disabled checkboxes and design fixes
c435bfe 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Aug 16, 2018
@skjnldsv
Copy link
Member Author

Updated! :)

rullzer
rullzer approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets do this 🐘

juliusknorr
juliusknorr approved these changes Aug 16, 2018
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice 👍

@juliusknorr juliusknorr merged commit a4e042c into master Aug 16, 2018
@juliusknorr juliusknorr deleted the sharing-public-settings-fixes branch August 16, 2018 07:39
@nextcloud-bot nextcloud-bot mentioned this pull request Oct 2, 2018
Closed
@nextcloud-bot nextcloud-bot mentioned this pull request Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@schiessle schiessle Awaiting requested review from schiessle

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: sharing high regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @juliusknorr @rullzer