Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only send an update sort order request if there is an user #10738

Merged
merged 3 commits into from
Aug 20, 2018
Merged

Only send an update sort order request if there is an user #10738

merged 3 commits into from
Aug 20, 2018

Conversation

weeman1337
Copy link
Member

  • Before sending an update sort order request it's checked whether there is an user logged in
  • Adds a test for that

closes #10669

@weeman1337
Adds a test to check that the sorting isn't stored without an user
f18fc85 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337
Stores the sorting only if there is an user
887737f 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 added this to the Nextcloud 14 milestone Aug 17, 2018
@weeman1337 weeman1337 changed the title Only sends an update sort order request if there is an user Only send an update sort order request if there is an user Aug 17, 2018
@weeman1337
Improves the tests
2de34d7 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 added 3. to review Waiting for reviews and removed 3. to review Waiting for reviews labels Aug 17, 2018
@blizzz blizzz requested review from ChristophWurst and removed request for LukasReschke August 17, 2018 22:10
@blizzz
Copy link
Member

blizzz commented Aug 17, 2018

Do we also have a positive test, ensuring that the request is sent when the user is logge in?

@weeman1337
Copy link
Member Author

@blizzz yes, see

server/apps/files/tests/js/filelistSpec.js

Line 2648 in 2de34d7

// check if changes are persisted

@blizzz blizzz merged commit 1b1c8b3 into master Aug 20, 2018
@blizzz blizzz deleted the fix/10669/store-sorting-only-for-loggedin-users branch August 20, 2018 12:54
@rullzer rullzer mentioned this pull request Aug 24, 2018
Closed
3 tasks
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Sep 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@blizzz blizzz blizzz approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@danxuliu danxuliu Awaiting requested review from danxuliu

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug regression
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.

Class/service 'Tagger' not found.
3 participants
@weeman1337 @blizzz @rullzer