Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a vendor prefix for position sticky #10747

Merged
merged 1 commit into from
Aug 20, 2018
Merged

Conversation

weeman1337
Copy link
Member

@weeman1337 weeman1337 commented Aug 19, 2018

Safari needs a vendor prefix for position: sticky;.

closes #10745

@weeman1337 weeman1337 added bug design Design, UI, UX, etc. labels Aug 19, 2018
position: sticky;
} @else {
position: sticky;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

position: $value; ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh you saw it before I could fix it ;)

Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@weeman1337 weeman1337 force-pushed the fix/10745/sticky-safari branch from f7ed2a1 to 18b677e Compare August 19, 2018 10:02
@weeman1337 weeman1337 added the 3. to review Waiting for reviews label Aug 19, 2018
@weeman1337 weeman1337 added this to the Nextcloud 14 milestone Aug 19, 2018
@skjnldsv
Copy link
Member

skjnldsv commented Aug 20, 2018

@juliushaertl do we want to introduce a mixin for two sticky only? :)

@weeman1337
Copy link
Member Author

@skjnldsv the idea was to not duplicate logic. If we find out that e.g. IE freaks out with that too, it's just one place to change.

@skjnldsv
Copy link
Member

@weeman1337 Yes, I understand your logic :)
It's just that adding 15 lines instead of 3 for a function that only supports position with a webkit prefix is maybe a bit too much ;)

@juliusknorr
Copy link
Member

I'd say the mixin makes sense here. We need a position fixed fallback for IE when sticky is applied anyway. So better have that grouped together.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in then :)

@juliusknorr juliusknorr merged commit 6e10358 into master Aug 20, 2018
@juliusknorr juliusknorr deleted the fix/10745/sticky-safari branch August 20, 2018 13:12
@rullzer rullzer mentioned this pull request Aug 24, 2018
3 tasks
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NC 14] Sidebar close icon; incompatible 'position: sticky' in Safari
4 participants