-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a vendor prefix for position sticky #10747
Conversation
core/css/functions.scss
Outdated
position: sticky; | ||
} @else { | ||
position: sticky; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
position: $value; ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Argh you saw it before I could fix it ;)
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
f7ed2a1
to
18b677e
Compare
@juliushaertl do we want to introduce a mixin for two sticky only? :) |
@skjnldsv the idea was to not duplicate logic. If we find out that e.g. IE freaks out with that too, it's just one place to change. |
@weeman1337 Yes, I understand your logic :) |
I'd say the mixin makes sense here. We need a position fixed fallback for IE when sticky is applied anyway. So better have that grouped together. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's get this in then :)
Safari needs a vendor prefix for
position: sticky;
.closes #10745