prefer using dir instead of allinfo for getting smb file info #10803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
reviewed
Aug 22, 2018
| } | ||
|
|
||
| // fallback to server timezone | ||
| $this->timeZone = date_default_timezone_get(); |
There was a problem hiding this comment.
This will just overwrite the stuff above...
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
icewind1991
force-pushed
the
smb-dir-instead-of-allinfo
branch
from
4de5ded
to
bf7fb2b
Compare
|
As this is in 3rdparty: shouldn't upstream be updated first? |
MorrisJobke
approved these changes
Aug 24, 2018
MorrisJobke
added
4. to release
|
Triggered CI again: https://drone.nextcloud.com/nextcloud/server/9856 |
Signed-off-by: Robin Appelman <robin@icewind.nl>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some windows server setups don't seem to like the allinfo command use the dir command instead to get the file info where possible.
Also includes some improvements for the timezone detection to properly handle cases where the command errors out.