Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mimetype detection for junked uploads #10828

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Fix mimetype detection for junked uploads #10828

merged 1 commit into from
Aug 24, 2018

Conversation

nickvergessen
Copy link
Member

Fix nextcloud/files_accesscontrol#108

  1. Enable Files access control
  2. Add rule to block file mimetype is application/x-ms-dos-executable
  3. Download one from https://download.nextcloud.com/desktop/releases/Windows/
  4. Upload it
  5. Should be blocked, but still works.

@nickvergessen
Fix mimetype detection for junked uploads
c574212 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 14 milestone Aug 24, 2018
This was referenced Aug 24, 2018
Closed
Merged
rullzer
rullzer approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should really add integration tests for this as well.

@rullzer rullzer mentioned this pull request Aug 24, 2018
Closed
3 tasks
MorrisJobke
MorrisJobke approved these changes Aug 24, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit d8e876c into master Aug 24, 2018
@MorrisJobke MorrisJobke deleted the bugfix/fac-108/mimetype-detection-broken-for-junked-uploads branch August 24, 2018 15:23
@MorrisJobke MorrisJobke mentioned this pull request Aug 24, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@mathiasconradt mathiasconradt Awaiting requested review from mathiasconradt

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug feature: workflows
Projects
None yet
Milestone
Nextcloud 14
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @rullzer @MorrisJobke