Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix icons cacher regex for compressed output #10847

Merged
merged 1 commit into from
Sep 19, 2018
Merged

Fix icons cacher regex for compressed output #10847

merged 1 commit into from
Sep 19, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Aug 24, 2018 •
edited
Loading

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

Fix #11131

@skjnldsv skjnldsv added bug 3. to review Waiting for reviews feature: scss feature: caching Related to our caching system: scssCacher, jsCombiner... labels Aug 24, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Aug 24, 2018
@skjnldsv skjnldsv self-assigned this Aug 24, 2018
@MorrisJobke
Copy link
Member

@skjnldsv many acceptance tests fail

@MorrisJobke
Copy link
Member

Old CI job: https://drone.nextcloud.com/nextcloud/server/9903
Retriggered one: https://drone.nextcloud.com/nextcloud/server/9908

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 25, 2018
@rullzer
Copy link
Member

rullzer commented Aug 26, 2018

Acceptence tests are not happy: https://drone.nextcloud.com/nextcloud/server/9918

@rullzer rullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Aug 26, 2018
@MorrisJobke MorrisJobke mentioned this pull request Aug 26, 2018
Merged
6 tasks
@skjnldsv
Copy link
Member Author

Wow, this change is generating an error 500 on every acceptance test! 😕

@skjnldsv
Copy link
Member Author

@danxuliu any ideas?

@vwbusguy
Copy link

vwbusguy commented Aug 30, 2018 •
edited
Loading

Does the test environment have the Bookmarks app enabled or one of the others that currently causes 500s in 14rc1? That would explain the missing element on the apps page, etc. Re: #10920 and nextcloud/bookmarks#542
I can't imagine how this valid regex change for CSS would have any of these effects.

@vwbusguy vwbusguy mentioned this pull request Aug 30, 2018
Closed
@MorrisJobke
Copy link
Member

Does the test environment have the Bookmarks app enabled or one of the others that currently causes 500s in 14rc1? That would explain the missing element on the apps page, etc. Re: #10920 and nextcloud/bookmarks#542

No - the tests are server core only.

@rullzer
Copy link
Member

rullzer commented Aug 30, 2018

14 or 15?

@skjnldsv
Copy link
Member Author

@rullzer this is a required fix for 14, but I cannot find a proper way to do so :(
This is not a hardbreaking change though. Just affect the dark theme that is set as 'beta' anyway.

@MorrisJobke
Copy link
Member

@rullzer this is a required fix for 14, but I cannot find a proper way to do so :(
This is not a hardbreaking change though. Just affect the dark theme that is set as 'beta' anyway.

Let's not block the 14.0.0 release then.

@skjnldsv
Copy link
Member Author

I'm fine with that!

@rullzer
Copy link
Member

rullzer commented Sep 4, 2018

@danxuliu any idea why this breaks everything?

@skjnldsv skjnldsv mentioned this pull request Sep 10, 2018
Closed
@danxuliu
Copy link
Member

any idea why this breaks everything?

Finally I do; the acceptance tests in this pull request should no longer fail if it is rebased after #11268 is merged.

@nickvergessen nickvergessen mentioned this pull request Sep 19, 2018
Merged
@blizzz blizzz modified the milestones: Nextcloud 14.0.1, Nextcloud 15 Sep 19, 2018
@blizzz
Copy link
Member

blizzz commented Sep 19, 2018

set milestone to 15 as it is against master.

@skjnldsv @danxuliu
Fix icons cacher regex for compressed output
3095ec4 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@danxuliu danxuliu added 3. to review Waiting for reviews and removed help wanted 2. developing Work in progress labels Sep 19, 2018
@danxuliu
Copy link
Member

Rebased onto master now that #11268 was merged.

@skjnldsv
Copy link
Member Author

skjnldsv commented Sep 19, 2018 •
edited
Loading

Failure looks unrelated, I restarted just in case.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2018
@skjnldsv
Copy link
Member Author

That's what I thought @nickvergessen can you merge? :)

@skjnldsv skjnldsv mentioned this pull request Sep 19, 2018
Merged
@nickvergessen nickvergessen merged commit 12977a2 into master Sep 19, 2018
@nickvergessen nickvergessen deleted the fix-icons-cacher branch September 19, 2018 14:00
@meminens
Copy link

meminens commented Nov 5, 2018

Same issue? nextcloud/tasks#214

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caching Related to our caching system: scssCacher, jsCombiner... feature: scss high
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
9 participants
@skjnldsv @MorrisJobke @rullzer @vwbusguy @danxuliu @blizzz @meminens @juliushaertl @nickvergessen