-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes the notifications area width equal to the contents #10881
Conversation
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Works like a charm. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't it uses the standard of the .menu behaviour?
I cannot test right now. @juliushaertl ?
@skjnldsv Do you mean to show them in a popover menu? Not sure if I get you correct there. |
@juliushaertl this or touches the notification area in the header right? |
@skjnldsv Not sure about adding them to the notifications area, since those are rather temporary notifications, but yes, we should improve the rendering for that. There already was an issue about that but I cannot find it right now. However I'd still just get this into 14 and improve the general rendering later. |
@weeman1337 sorry, I was reading on my mobile, I mistaken the code for something else :) |
closes #10705