Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Drozone to favorites quickaccess #10908

Closed

Conversation

newhinton
Copy link
Contributor

This adds the ability to drop a folder on the quickaccess and add it to it

Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
…ntry from the list if it was already present

Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
Signed-off-by: Felix Nüsse <Felix.nuesse@t-online.de>
@skjnldsv skjnldsv force-pushed the feature/noid/favorites-quickaccess-add-droppable-v2 branch from 6bd1ea6 to d96a4d2 Compare October 2, 2018 06:18
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The drop background stays after I stopped dragging :)
  • If you remove the last directory from the favorite and add a new one it doesn't get appended to the quickaccess list :)

Otherwise it works great on files and folder!

@newhinton
Copy link
Contributor Author

If i remember correctly #10888 should fix the second isssue, but ill have to look into the first one :D

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 2, 2018
@MorrisJobke
Copy link
Member

@newhinton Just change the labels from "2. developing" to "3. to review" once you are done with your changes ;)

@MorrisJobke
Copy link
Member

@newhinton Could you rebase this one please? Thanks :)

@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
29 tasks
@MorrisJobke
Copy link
Member

Let's move this one to 16.

@newhinton
Copy link
Contributor Author

See #12917

@newhinton newhinton added the 3. to review Waiting for reviews label Dec 17, 2018
@jancborchardt
Copy link
Member

jancborchardt commented Dec 21, 2018

@newhinton so should we close this in favor of #12917 ?

@newhinton
Copy link
Contributor Author

@jancborchardt yes, i wasnt shure if it was the proper thing todo ;)

@newhinton newhinton closed this Dec 21, 2018
@jancborchardt jancborchardt deleted the feature/noid/favorites-quickaccess-add-droppable-v2 branch December 21, 2018 02:55
@MorrisJobke MorrisJobke removed this from the Nextcloud 16 milestone Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress 3. to review Waiting for reviews design Design, UI, UX, etc. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants