Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup filecache database handling a bit #10921

Closed
wants to merge 2 commits into from
Closed

cleanup filecache database handling a bit #10921

wants to merge 2 commits into from

Conversation

icewind1991
Copy link
Member

Move building queries as string over to the query builder

@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Aug 29, 2018
@icewind1991 icewind1991 added this to the Nextcloud 15 milestone Aug 29, 2018
MorrisJobke
MorrisJobke previously requested changes Aug 30, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See typo

@MorrisJobke MorrisJobke added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Aug 30, 2018
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 12, 2018
@rullzer rullzer force-pushed the cache-db-cleanup branch 2 times, most recently from 7ffe66c to caa096c Compare October 2, 2018 17:38
MorrisJobke
MorrisJobke approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍 Code change looks also good

rullzer
rullzer approved these changes Oct 2, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 2, 2018
@rullzer
Copy link
Member

rullzer commented Oct 2, 2018

Phan is not happy
https://drone.nextcloud.com/nextcloud/server/10970/274

@rullzer rullzer added 2. developing Work in progress and removed 4. to release Ready to be released and/or waiting for tests to finish labels Oct 2, 2018
@icewind1991 icewind1991 force-pushed the cache-db-cleanup branch 2 times, most recently from a3923d9 to f3c5809 Compare October 17, 2018 15:04
@icewind1991
cleanup filecache database handling a bit
6f0c611 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991
dont check the first parameter to setValue/set in sqlite injectio…
a580b97 
…n checker

Signed-off-by: Robin Appelman <robin@icewind.nl>
@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
Merged
29 tasks
@MorrisJobke
Copy link
Member

Phan is still not happy :/

@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2018
Merged
24 tasks
@rullzer rullzer closed this Feb 4, 2019
@rullzer rullzer deleted the cache-db-cleanup branch February 4, 2019 09:33
@MorrisJobke MorrisJobke removed this from the Nextcloud 16 milestone Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

Assignees
No one assigned
Labels
2. developing Work in progress technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@icewind1991 @rullzer @MorrisJobke