Fix interaction with groups that contain a slash #11200
Conversation
nickvergessen
added
bug
2. developing
| @@ -51,7 +51,7 @@ export default new Router({ | |||
| name: 'users', | |||
| children: [ | |||
| { | |||
| path: ':selectedGroup', | |||
| path: ':selectedGroup(.*)', | |||
There was a problem hiding this comment.
No, this is working fine.
We need to encode the variables in the ocs requests instead.
Request URL: https://dev.skjnldsv.com/ocs/v2.php/cloud/groups/Test/1/users/details?offset=0&limit=25&search=
Should be /ocs/v2.php/cloud/groups/Test%2F1/users/details
There was a problem hiding this comment.
No, the old URL works since Nextcloud 9 and should not require urlencoding all of a sudden.
|
It fixes #11110, right? |
|
@MorrisJobke no idea :/ |
|
@nickvergessen @skjnldsv Mind to rebase this one? |
Signed-off-by: Joas Schilling <coding@schilljs.com>
MorrisJobke
force-pushed
the
bugfix/2954/interaction-with-groups-containing-a-slash
branch
from
129317d to
1997346
Compare
|
Rebased and rebuild the JS assets. |
MorrisJobke
added
4. to release
MorrisJobke
deleted the
bugfix/2954/interaction-with-groups-containing-a-slash
branch
|
/backport to stable14 |
|
/backport to stable13 |
|
The backport to stable13 failed. Please do this backport manually. |
1 similar comment
|
The backport to stable13 failed. Please do this backport manually. |
|
/backport to stable14 |
|
The backport to stable14 failed. Please do this backport manually. |
|
/backport to stable15 |
|
The backport to stable15 failed. Please do this backport manually. |
@skjnldsv can you help? The Vue-router seems to escape the placeholders
So when you open a group which contains a slash and reload the page, it breaks.
https://localhost/index.php/settings/users/test%2Fusers
with
https://localhost/index.php/settings/users/test/users it works quite fine.
Fixes #11110