Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the logo height #11384

Merged
merged 1 commit into from
Sep 27, 2018
Merged

Fixes the logo height #11384

merged 1 commit into from
Sep 27, 2018

Conversation

weeman1337
Copy link
Member

@weeman1337 weeman1337 commented Sep 26, 2018 •
edited
Loading

before
image

after
image

Closes #11372

@weeman1337 weeman1337 added design Design, UI, UX, etc. 3. to review Waiting for reviews papercut Annoying recurring issue with possibly simple fix. labels Sep 26, 2018
@weeman1337 weeman1337 mentioned this pull request Sep 26, 2018
Merged
skjnldsv
skjnldsv reviewed Sep 26, 2018
View reviewed changes
core/css/header.scss Outdated
@@ -113,7 +113,7 @@
background-size: contain;
background-position: center;
width: 62px;
height: 100%;
height: calc(100% - 2px);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cinfused, where does those 2px come from? 🤔 😁

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv it has top: 1px;. When there should be the same at the bottom a height of 100 % minus two pixels would to that.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we set a top at 0?
I remember something about this, but I can't recall 😁

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found the guilty man: #10853
Damn you @skjnldsv!!!!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha ha :) I tried it without the tiny spacing. In my opinion it looks better like this...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could add a bottom: 1px? so we understand better?
I'm fine with that, but i'm afraid we'll forget about this like I did above 😝

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv done ✓

@weeman1337 weeman1337 force-pushed the 11372/fix/logo-height branch from f948916 to 46bd4c4 Compare September 26, 2018 10:37
@go2sh
Copy link
Contributor

go2sh commented Sep 26, 2018

I tested it also. 👍

@skjnldsv
Copy link
Member

@go2sh you should be able to add your review on the top right ;)

go2sh
go2sh approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@go2sh go2sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. :)

@weeman1337 @rullzer
Fixes the logo height
c7714b4 
Signed-off-by: Michael Weimann <mail@michael-weimann.eu>
@rullzer rullzer force-pushed the 11372/fix/logo-height branch from 46bd4c4 to c7714b4 Compare September 27, 2018 10:47
@rullzer rullzer merged commit fbe270d into master Sep 27, 2018
@rullzer rullzer deleted the 11372/fix/logo-height branch September 27, 2018 13:41
@MorrisJobke
Copy link
Member

@weeman1337 Once the backport PR is open you could remove the backport-request label. Because we go regularly through the closed PRs that still have the label to backport those. This then makes it easier for us to spot the not yet backported. Just a little hint for the future and to explain how we work. :)

@MorrisJobke MorrisJobke added this to the Nextcloud 15 milestone Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@go2sh go2sh go2sh approved these changes

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review Waiting for reviews design Design, UI, UX, etc. papercut Annoying recurring issue with possibly simple fix.
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
5 participants
@weeman1337 @go2sh @skjnldsv @MorrisJobke @rullzer