Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple handlebars CI step #11444

Merged
merged 3 commits into from
Oct 1, 2018
Merged

Simple handlebars CI step #11444

merged 3 commits into from
Oct 1, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Sep 28, 2018

Fixes #11413

@rullzer
Add script to compile handlebars templates
f4a15f7 
For now it is small and there is no real standard yet. But it is better
to start with something.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 2. developing Work in progress label Sep 28, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Sep 28, 2018
@rullzer rullzer force-pushed the feature/11413/handlebars_compile_step branch from 8f6ea91 to 4a781a5 Compare September 28, 2018 19:10
@rullzer
Add drone step
4f13430 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the feature/11413/handlebars_compile_step branch from 162a6ad to 28b4439 Compare September 28, 2018 19:15
@rullzer
Bump templates to handlebars 4.0.12
7e5b7f7 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer force-pushed the feature/11413/handlebars_compile_step branch from 28b4439 to 7e5b7f7 Compare September 28, 2018 19:17
@rullzer rullzer added enhancement 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 28, 2018
@rullzer
Copy link
Member Author

rullzer commented Sep 28, 2018

I'd say lets get this in and slowly improve the script.

@ChristophWurst ChristophWurst merged commit 23ba41e into master Oct 1, 2018
@ChristophWurst ChristophWurst deleted the feature/11413/handlebars_compile_step branch October 1, 2018 07:41
@danxuliu danxuliu mentioned this pull request Nov 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @skjnldsv @ChristophWurst