Fix "Uninitialized string offset: 0 at Node.php"

[enoch85]

Signed-off-by: Daniel Hansson daniel@hanssonit.se

Add the suggested fix in #10262 which without this fix spams the log with Uninitialized string offset: 0 at Node.php#290

cc @MorrisJobke

[enoch85]

Backport stable 14: #11466

[enoch85]

Backport stable 13 #11467

[MorrisJobke]

Backport stable 14: #11466

Only do back ports once they are requested. And please use descriptive issue titles, because "fix #10262" doesn't help anybody. That should be within the description of the PR.

[MorrisJobke]

This is hiding the symptoms and not fixing the cause. The function is called with null even if only string should be handed in into this method. Thus the root cause it to search somewhere else. Could you first try the patch from #10262 (comment) to find it.

[enoch85]

This solved my problem and my log isn't spammed anymore on 14.0.1. I'm no PHP developer so I don't have a clue what this does, just trying to help out here since a PR was requested with the fix in the original issue. 👼

[MorrisJobke]

Sure it solved the symptoms, but still we should not hide them but actually look why it is happening. THat's the reason I asked you to apply the patch, because it logs actually useful information that I or any other developer could use then to properly analyze the problem. 😉

[enoch85]

@MorrisJobke Gotcha! Will edit the original post.

[enoch85]

Feel free to close this and fix the cause of the issue. I want clean logs, but at the same time I totally get that we should fix the the cause.

[enoch85]

OK, so I should add this instead:

		if ($path === null) {
			\OC::$server->getLogger()->logException(new \Exception(), ['app' => 'debug-empty-path']);
			return '/';
		}

[MorrisJobke]

@enoch85 Correct 👍

[MorrisJobke]

It will for now do the same, but also log some stack trace. You could remove the line with the logger once you have some stack traces.

[enoch85]

You could remove the line with the logger once you have some stack traces.

Oh! I thought that was the fix. :D