Reduce the min-width of the files table so it works on sharing pages on mobile #11508
+2
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jancborchardt
added
bug
design
jancborchardt
requested review from
MorrisJobke,
kevgathuku,
pixelipo and
skjnldsv
No idea unfortunately. |
skjnldsv
approved these changes
Oct 1, 2018
weeman1337
approved these changes
Oct 1, 2018
…on mobile Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
rullzer
force-pushed
the
files-list-width-sharing
branch
from
447cd31 to
9cd048c
Compare
|
Backport at #11556 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was introduced in #9982 via 43ab208 – cc @skjnldsv was there a specific reason there?
The issue is that for public sharing pages, only the 500px is in effect. There’s not really a reason to limit it either way as far as I can see? Tested when logged in on various widths too.
Probably should be backported cause public shares on mobile are kinda broken due to this?
Before, way too wide when cut off:
After, goes down to reasonable last useful width:
Please review @nextcloud/designers