Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the min-width of the files table so it works on sharing pages on mobile #11508

Merged
merged 1 commit into from
Oct 2, 2018

Conversation

jancborchardt
Copy link
Member

This was introduced in #9982 via 43ab208 – cc @skjnldsv was there a specific reason there?

The issue is that for public sharing pages, only the 500px is in effect. There’s not really a reason to limit it either way as far as I can see? Tested when logged in on various widths too.

Probably should be backported cause public shares on mobile are kinda broken due to this?

Before, way too wide when cut off:
screenshot from 2018-10-01 12-36-22

After, goes down to reasonable last useful width:
screenshot from 2018-10-01 12-35-52

Please review @nextcloud/designers

@skjnldsv
Copy link
Member

skjnldsv commented Oct 1, 2018

This was introduced in #9982 via 43ab208 – cc @skjnldsv was there a specific reason there?

The issue is that for public sharing pages, only the 500px is in effect. There’s not really a reason to limit it either way as far as I can see? Tested when logged in on various widths too.

No idea unfortunately.
It's always a matter of fixing something somewhere on files and seeing a conflicting rule break somewhere else :(

…on mobile

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
@jancborchardt
Copy link
Member Author

Backport at #11556

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: sharing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants