Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added cache override to ensure an always up-to-date accessibility css #11533

Merged
merged 1 commit into from
Oct 24, 2018
Merged

Added cache override to ensure an always up-to-date accessibility css #11533

merged 1 commit into from
Oct 24, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 2, 2018

Fix #10960

@skjnldsv
Added cache override to ensure an always up-to-date accessibility css
cf06e31 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Oct 2, 2018
@skjnldsv skjnldsv self-assigned this Oct 2, 2018
@MorrisJobke
Copy link
Member

🏓 for the review 😉

@skjnldsv
Copy link
Member Author

Even I forgot about this pr 😁

rullzer
rullzer approved these changes Oct 23, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably not the most performant way. But we cache agressively. So yeah lets go for it.

MorrisJobke
MorrisJobke approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit 2ec5d2a into master Oct 24, 2018
@MorrisJobke MorrisJobke deleted the accessibility-cache-fixes branch October 24, 2018 13:04
@jospoortvliet
Copy link
Member

Great work guys! Several ppl did indeed point it out about 14.0.3 - still has this issue. 15 is fine, though, it isn't something that hits users in day-to-day so much, you pick one theme and stick with it, usually.

@MorrisJobke
Copy link
Member

@skjnldsv Could you backport it?

@MorrisJobke
Copy link
Member

@skjnldsv Could you backport it?

@skjnldsv 🏓

@skjnldsv skjnldsv mentioned this pull request Nov 13, 2018
Merged
@skjnldsv
Copy link
Member Author

backport In #12432

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@jospoortvliet jospoortvliet Awaiting requested review from jospoortvliet

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliushaertl juliushaertl Awaiting requested review from juliushaertl

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug feature: accessibility
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@skjnldsv @MorrisJobke @jospoortvliet @rullzer