Adjust border-radius-large to fit with padding of modals

[jancborchardt]

So the border-radius doesn’t have to be chosen just willy-nilly, but we have an anchor point and that are the buttons on the bottom (or generally elements inside):

This is how it looks in this pull request: 15px border-radius, to fit the 15px padding of .oc-dialog:

This is how it was after my pull request – yes that’s too big (but also accounted for the margin of the buttons):

This is 10px (would also happen with less), creating a bump → for reference see this admittedly quite old article, cause it’s an old issue:

[skjnldsv]

10px is decent I guess. But 15 is still too big.

Why this sudden change? I mean, this doesn't really add anything ux speaking, this is obviously just a matter of visual ease. But I don't see what made you go for this? Did you saw it somewhere else (macOS you said?)
Because big rounder radiuses like that are nowhere being used on usual software I usually use. It's actually the opposite now, we're used to professional looking ui which are square with tiny radius.
Big rounds are more for a funky look.

[skjnldsv]

Though good reading: https://hackernoon.com/apples-icons-have-that-shape-for-a-very-good-reason-720d4e7c8a14

[skjnldsv]

This is 10px (would also happen with less), creating a bump → for reference see this admittedly quite old article, cause it’s an old issue:

Don't try to lure me with articles with 🐍 😁

[pixelipo]

@jancborchardt that article is talking about double border, not about rounded items withing rounded items, so I'm not sure it's relevant to this topic. And if it was, that would actually mean we would have to update corners for popovers as well - since those can also contain buttons (example: notifications).

From what I see, new macOS doesn't follow this rule either - buttons are still way more rounded that modalRadius-padding rule would require.

P.S. Personally, the 10px radius is most eye-candy for me :)

[jancborchardt]

that article is talking about double border, not about rounded items withing rounded items

@pixelipo I know, but when the buttons are on the corner, it’s basically the same effect.

Though good reading: https://hackernoon.com/apples-icons-have-that-shape-for-a-very-good-reason-720d4e7c8a14

@skjnldsv Yup, normal rounded corners have visible "tips" at the start of the rounded corners – we can definitely look at that once … I guess CSS15 introduces that ability. ;D

P.S. Personally, the 10px radius is most eye-candy for me :)

@pixelipo alright – adjusted it to 10px. :) Please review.