Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sticky header on users list #11581

Merged
merged 2 commits into from
Oct 4, 2018
Merged

Fix sticky header on users list #11581

merged 2 commits into from
Oct 4, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 3, 2018

Fix #11541
capture d ecran_2018-10-03_12-10-02

@XjeEDK @nextcloud/designers

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@ChristophWurst
Copy link
Member

I wonder if it would look better if there were a little border on the bottom of the header 🤔

@MorrisJobke
Copy link
Member

I wonder if it would look better if there were a little border on the bottom of the header 🤔

Thought the same 👍

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the issue with the sticky header. 👍 Bonus points for a border at the bottom of the header.

@pixelipo
Copy link
Contributor

pixelipo commented Oct 3, 2018

Yeah, this definitely needs the bottom border.

However, I don't much like having two sticky lines. Makes more sense for the actual header to be sticky then for the "add user" form. Perhaps we could make the latter non-sticky and make the #new-user-button into a <a href="/#newuser"> to always jump back to it wherever we are down the list?

@skjnldsv
Copy link
Member Author

skjnldsv commented Oct 3, 2018

@pixelipo the new user header is only here if you click the new user button :)
So you can toggle it.
Most common case is only the header ;)

Copy link
Member

@weeman1337 weeman1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks so much better 👍

@MorrisJobke
Copy link
Member

@skjnldsv Could you back port this small change as well?

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2018
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@skjnldsv skjnldsv merged commit 0b27595 into master Oct 4, 2018
@skjnldsv skjnldsv deleted the users-table-header-fix branch October 4, 2018 07:05
@MorrisJobke
Copy link
Member

@skjnldsv Could you back port this small change as well?

#11608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: users and groups
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants