-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sticky header on users list #11581
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
I wonder if it would look better if there were a little border on the bottom of the header 🤔 |
Thought the same 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes the issue with the sticky header. 👍 Bonus points for a border at the bottom of the header.
Yeah, this definitely needs the bottom border. However, I don't much like having two sticky lines. Makes more sense for the actual header to be sticky then for the "add user" form. Perhaps we could make the latter non-sticky and make the |
@pixelipo the new user header is only here if you click the new user button :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✓
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks so much better 👍
@skjnldsv Could you back port this small change as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Fix #11541
@XjeEDK @nextcloud/designers