Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require Same Site Cookies on assets #11878

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

tcitworld
Copy link
Member

Which can be used for public iframe embeeding

See nextcloud/calendar#169

Which can be used for public iframe embeeding

See nextcloud/calendar#169

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

Those endpoints are PublicPage anyway already. So people can obtain the info by a direct query.
So no leaking of info here.

@blizzz blizzz merged commit 0c05ed1 into master Oct 18, 2018
@blizzz blizzz deleted the no-require-same-site-cookie-on-assets branch October 18, 2018 08:25
tcitworld added a commit that referenced this pull request Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants