Forwarded ExpiredTokenException

[rullzer]

Fixes #11919

This fixes an issue when the oauth part requests a token that is expired. Because of the migration path it woudl just return the InvalidTokenException instead of the ExpiredTokenException resulting in not renewing the token properly.

This was working all properly when introduced. But it got broken by the move to the PublicKey Tokens.

Guess this means time for integration and acceptance tests on the OAuth endpoint. I just need to think how to make the tokens directly expire then ;)

CC: @Dagefoerde

[Dagefoerde]

Whoa, I shouldn't debug things that rely on an internet connection while I am on the train 😱 I was going to say your fix doesn't work, but: no, it does!
...at least it seams so for now. I still don't know after which amount of time it was invalidated previously, so I am going to test this again in the morning.

Guess this means time for integration and acceptance tests on the OAuth endpoint.

Yess! 👍 :)

Will report back tomorrow. Thanks for now, @rullzer! :)

[rullzer]

I still don't know after which amount of time it was invalidated previously, so I am going to test this again in the morning.

Normal time out for a token is an hour

[Dagefoerde]

was 4 hours, so that's covered :)

[kesselb]

I had troubles reproducing the issue. There is some logic to handle ExpiredTokenException in

server/apps/oauth2/lib/Controller/OauthApiController.php

Lines 138 to 139 in 3556e78

	} catch (ExpiredTokenException $e) {
	$appToken = $e->getToken();

so it looks right to me to throw the exception up.

[rullzer]

@danielkesselberg yeah it is tricky to fake. Requires a lot of waiting etc. Or manual manipulation. I'll try to come up with writing acceptance tests so we can make sure it keeps working ;)

[Dagefoerde]

@rullzer I know I didn't really need to test this anymore, but I did so anyway. :D the issue remains solved as I successfully got a new token this morning. Thanks again.

I think manual manipulation would be the way to go, right? Like changing the expires timestamp to something two hours ago...

(Either GitHub or I have connectivity issues. I removed the spare comments...)

[Dagefoerde]

@rullzer I know I didn't really need to test this anymore, but I did so anyway. :D the issue remains solved as I successfully got a new token this morning. Thanks again.

I think manual manipulation would be the way to go, right? Like changing the expires timestamp to something two hours ago...

(Either GitHub or I have connectivity issues. I removed the spare comments...)

[ChristophWurst]

Makes sense!