Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title attribute for app navigation items. #12090

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Add title attribute for app navigation items. #12090

merged 2 commits into from
Feb 1, 2019

Conversation

AasthaGupta
Copy link
Member

@AasthaGupta AasthaGupta commented Oct 28, 2018 •
edited
Loading

Fix: #11923

@AasthaGupta AasthaGupta requested a review from skjnldsv October 28, 2018 05:59
@AasthaGupta
Copy link
Member Author

Made some changes in the appNavigationItem.vue: nextcloud-libraries/nextcloud-vue#73

@skjnldsv
Copy link
Member

Hey!
You also need to ship the compiled file for the tests to pass 😉

@MorrisJobke
Copy link
Member

You also need to ship the compiled file for the tests to pass 😉

@skjnldsv Could you provide the command that builds the JS files? That would help a lot I guess.

@jancborchardt
Copy link
Member

Any update here? Seems it was fixed in the components already, so should go in here too. :) @skjnldsv if you don’t mind, can you just compile the files? (Also – we need documentation there. ;)

@skjnldsv
Copy link
Member

(Also – we need documentation there. ;)

Hopefully we will have upgraded the modules to better suitable vue ones

@MorrisJobke
Copy link
Member

It looks like a push went wrong :( Could we somehow help you to resolve the issues in the git history here?

AasthaGupta and others added 2 commits January 31, 2019 21:33
@AasthaGupta @rullzer
Add title attribute for app navigation items.
4658d69 
Fix: #11923
@rullzer
Generate assets
c07a16e 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member

rullzer commented Jan 31, 2019

I found the commit. Took it and compiled the asset.

Lets do this. 🚀

@rullzer rullzer added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jan 31, 2019
@rullzer rullzer added this to the Nextcloud 16 milestone Jan 31, 2019
skjnldsv
skjnldsv approved these changes Jan 31, 2019
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/nextcloud/nextcloud-vue/blob/bf2e56ee3b017dd09040acf07cbd3c2f6ef231b4/src/components/AppNavigationItem/AppNavigationItem.vue#L30

Yes! 👍

@juliusknorr
Copy link
Member

Failure unrelated

@juliusknorr juliusknorr added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 1, 2019
@MorrisJobke MorrisJobke merged commit 0d22ea7 into master Feb 1, 2019
@MorrisJobke MorrisJobke deleted the aastha/11923 branch February 1, 2019 09:14
@MorrisJobke MorrisJobke restored the aastha/11923 branch February 1, 2019 09:14
@MorrisJobke MorrisJobke deleted the aastha/11923 branch February 1, 2019 09:14
@MorrisJobke MorrisJobke restored the aastha/11923 branch February 1, 2019 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rullzer rullzer rullzer approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Milestone
Nextcloud 16
Development

Successfully merging this pull request may close these issues.
6 participants
@AasthaGupta @skjnldsv @MorrisJobke @jancborchardt @rullzer @juliusknorr