Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .hidden class specificity, should not be overridable, ref #12138 #12167

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

jancborchardt
Copy link
Member

Follow-up fix to #12138 as described by @pixelipo

Please review @nextcloud/designers @violoncelloCH :)

Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Copy link
Contributor

@pixelipo pixelipo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving based only on the code-review. I haven't tested this in real life, but the code makes sense

Copy link
Member

@violoncelloCH violoncelloCH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works, however only tested locally in browser...
will need to create a dev setup... will probably try out https://github.com/jancborchardt/nextcloud-scripts/blob/master/nextcloud-setup.sh as soon as I'll get some spare time for it...

@violoncelloCH
Copy link
Member

as @te-online brought in the idea of display: inline-block, maybe you could take a look at this too?

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're too fast for me 😂😉
🚀

@jancborchardt
Copy link
Member Author

@violoncelloCH @pixelipo @kevgathuku @te-online @nextcloud/designers btw, it’s off-topic but we have an upcoming hackweek in Stuttgart, November 26-30! 😃 Everyone is welcome, and for contributors like you there’s 80% travel/lodging support as usual! 🎉 There will be a blog post the next few days with more info, but for now please mark your calendar, and hope to see you there! ❤️

@rullzer rullzer merged commit 3c442e4 into master Oct 31, 2018
@rullzer rullzer deleted the hidden-class branch October 31, 2018 19:30
@te-online
Copy link
Contributor

You're too fast for me 😂😉

For me too 😅

@rullzer
Copy link
Member

rullzer commented Oct 31, 2018

This broke the generation of apptokens in the webui.

  1. Go to your security settings
  2. Try to generate an apptokens
  3. Do not see your actual new apptoken.

@juliusknorr
Copy link
Member

juliusknorr commented Nov 1, 2018

This broke also the popover menu in files sharing. Probably all hidden items, that use some jquery code to show it. Maybe we should revert this and do the change in a less invasive way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants