-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .hidden class specificity, should not be overridable, ref #12138 #12167
Conversation
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving based only on the code-review. I haven't tested this in real life, but the code makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works, however only tested locally in browser...
will need to create a dev setup... will probably try out https://github.com/jancborchardt/nextcloud-scripts/blob/master/nextcloud-setup.sh as soon as I'll get some spare time for it...
as @te-online brought in the idea of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're too fast for me 😂😉
🚀
@violoncelloCH @pixelipo @kevgathuku @te-online @nextcloud/designers btw, it’s off-topic but we have an upcoming hackweek in Stuttgart, November 26-30! 😃 Everyone is welcome, and for contributors like you there’s 80% travel/lodging support as usual! 🎉 There will be a blog post the next few days with more info, but for now please mark your calendar, and hope to see you there! ❤️ |
For me too 😅 |
This broke the generation of apptokens in the webui.
|
This broke also the popover menu in files sharing. Probably all hidden items, that use some jquery code to show it. Maybe we should revert this and do the change in a less invasive way. |
Follow-up fix to #12138 as described by @pixelipo
Please review @nextcloud/designers @violoncelloCH :)