Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Calendarsubscriptions source column change on Oracle #12275

Merged
merged 1 commit into from
Nov 13, 2018
Merged

Fix Calendarsubscriptions source column change on Oracle #12275

merged 1 commit into from
Nov 13, 2018

Conversation

georgehrke
Copy link
Member

fixes #11975

@georgehrke georgehrke added this to the Nextcloud 15 milestone Nov 5, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 6, 2018
Merged
29 tasks
ChristophWurst
ChristophWurst previously requested changes Nov 7, 2018
View reviewed changes
apps/dav/lib/Migration/Version1008Date20181105104826.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105104826.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105104833.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105104833.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105110300.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105112049.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105112049.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1007Date20181007225117.php Outdated Show resolved Hide resolved
nickvergessen
nickvergessen reviewed Nov 7, 2018
View reviewed changes
apps/dav/appinfo/info.xml Outdated
@@ -5,7 +5,7 @@
<name>WebDAV</name>
<summary>WebDAV endpoint</summary>
<description>WebDAV endpoint</description>
<version>1.7.2</version>
<version>1.8.0</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.7.3 should be fine, I increase it directly after each major release 🙈

@georgehrke georgehrke force-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from fcfcd1b to b6e6308 Compare November 7, 2018 12:57
@georgehrke
Copy link
Member Author

Set version to 1.7.3 and removed the extra checks.

@georgehrke georgehrke dismissed stale reviews from nickvergessen and ChristophWurst November 7, 2018 12:58

All remarks have been addressed

ChristophWurst
ChristophWurst requested changes Nov 7, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If possible I'd suggest to do a column rename instead of the second copy. Apart from that it looks good!

apps/dav/lib/Migration/Version1008Date20181105104826.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105104833.php Outdated Show resolved Hide resolved
apps/dav/lib/Migration/Version1008Date20181105110300.php Outdated Show resolved Hide resolved
@georgehrke georgehrke force-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from b6e6308 to fa34a6b Compare November 7, 2018 13:18
@georgehrke

This comment has been minimized.

Sign in to view
@georgehrke

This comment has been minimized.

Sign in to view
@ChristophWurst

This comment has been minimized.

Sign in to view
ChristophWurst
ChristophWurst approved these changes Nov 7, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@skjnldsv
Copy link
Member

skjnldsv commented Nov 7, 2018

I just realized the naming of the files is : Version1008Datexxx which probably means version 10.0.8. :D

@georgehrke
Copy link
Member Author

I named it Version1008..., because there is already another migration starting with Version1008... and i wanted to keep the order right.

@nickvergessen
Copy link
Member

nickvergessen commented Nov 7, 2018 •
edited
Loading

I just realized the naming of the files is : Version1008Datexxx which probably means version 10.0.8.

No, if the version is X.Y.Z the migration name is XXXYYY without leading zeros of X

@MorrisJobke MorrisJobke added bug 3. to review Waiting for reviews labels Nov 7, 2018
@georgehrke georgehrke force-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from fa34a6b to 886e707 Compare November 7, 2018 16:40
@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2018
Merged
24 tasks
@MorrisJobke MorrisJobke force-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from 886e707 to a72713c Compare November 12, 2018 11:09
@MorrisJobke
Copy link
Member

Rebased to fix conflicts in autoloader.

@georgehrke @MorrisJobke
Fix Calendarsubscriptions source column change on Oracle
071301b 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@MorrisJobke MorrisJobke force-pushed the bugfix/11975/oracle_calendar_subscriptions_source branch from a72713c to 071301b Compare November 13, 2018 15:32
@MorrisJobke MorrisJobke merged commit 3c5e438 into master Nov 13, 2018
@MorrisJobke MorrisJobke deleted the bugfix/11975/oracle_calendar_subscriptions_source branch November 13, 2018 15:34
@nickvergessen nickvergessen mentioned this pull request Nov 16, 2018
Merged
@nickvergessen nickvergessen mentioned this pull request Dec 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blizzz blizzz blizzz left review comments

@MorrisJobke MorrisJobke MorrisJobke left review comments

@nickvergessen nickvergessen nickvergessen left review comments

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@rullzer rullzer Awaiting requested review from rullzer

Assignees
No one assigned
Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.

Installing on oracle fails
6 participants
@georgehrke @ChristophWurst @skjnldsv @nickvergessen @MorrisJobke @blizzz