Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not offer to change display name or password, if not possible. #12335

Merged
merged 1 commit into from
Nov 8, 2018

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 7, 2018

Fixes #12319

That's more a quick prototype, tests might fail, did not look for them.

Question: can we just extend the OCS endpoint with those additional data? In fact, it it could be more compact with the backend data as different result sets and users just pointing to the related backend feature set …

Also, it does not look very consistent. There should be an indicator whether a display name is editable or not, but that should not vary too much. That's something for CSS magicians howerver :)

usermgmt

@blizzz blizzz added this to the Nextcloud 15 milestone Nov 7, 2018
@blizzz blizzz requested review from rullzer and skjnldsv November 7, 2018 15:40
@MorrisJobke MorrisJobke mentioned this pull request Nov 7, 2018
29 tasks
:disabled="loading.displayName||loading.all"
:value="user.displayname" ref="displayName"
autocomplete="new-password" autocorrect="off" autocapitalize="off" spellcheck="false" />
<input type="submit" class="icon-confirm" value="" />
<input v-if="user.backendCapabilities.setDisplayName" type="submit" class="icon-confirm" value="" />
<div v-if="!user.backendCapabilities.setDisplayName" class="name">{{user.displayname}}</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could use v-else 😉

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can I combine previous same v-ifs?

Copy link
Member

@skjnldsv skjnldsv Nov 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inside a template yes

<template v-if="true">
    <input type="text" />
    <input type="submit" />
</template>
<div v-else />

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both aspects done

@johkoenig
Copy link
Member

I really appreciate how fast you put my feature request into real code. Thumbs up for that.

Also, it does not look very consistent. There should be an indicator whether a display name is editable or not, but that should not vary too much. That's something for CSS magicians howerver :)

What about adding a little (i) behind the display name which, when hovering over it, says "Username generated from $Backend information"?

@blizzz
Copy link
Member Author

blizzz commented Nov 7, 2018

I really appreciate how fast you put my feature request into real code. Thumbs up for that.

tbh, I think it is a long standing issue, just could not find the original bug report. Might be well from before-fork-times :D I was curious to see whether I could bake this in into the new frontend code for users management :)

What about adding a little (i) behind the display name which, when hovering over it, says "Username generated from $Backend information"?

A valid for statement LDAP, hypothetically not for other possible backends. But perhaps a tooltip that states that the values cannot be changed against the backend would suffice I guess.

Fixes #12319

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz blizzz force-pushed the fix/12319/respect-fixed-usernames branch from 5b72d15 to 505722c Compare November 7, 2018 21:37
@blizzz
Copy link
Member Author

blizzz commented Nov 7, 2018

Added the tooltip, updated the screenshot in the description

@blizzz blizzz added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 7, 2018
@johkoenig
Copy link
Member

tbh, I think it is a long standing issue, just could not find the original bug report. Might be well from before-fork-times :D I was curious to see whether I could bake this in into the new frontend code for users management :)
Not a problem. For me, the result's the same.

By the way, your current wording "The backend does not support changing the display name" is a little bit misleading. Despite what you say, the display name can be changed. The point is, it must be done in the backend. :-)
So, I propose something like "Display name is generated from backend data"

@blizzz
Copy link
Member Author

blizzz commented Nov 7, 2018

By the way, your current wording "The backend does not support changing the display name" is a little bit misleading. Despite what you say, the display name can be changed. The point is, it must be done in the backend. :-)

My intention is to refer to the backend in Nextcloud context, but you can argue it's a connector to the backend service. I had the same thoughts, but did not see it as much of a problem.

Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

@blizzz
Copy link
Member Author

blizzz commented Nov 8, 2018

need to touch users acceptance tests yet

@MorrisJobke MorrisJobke mentioned this pull request Nov 8, 2018
24 tasks
@blizzz
Copy link
Member Author

blizzz commented Nov 8, 2018

Okay, after wondering why it failed… it just passes locally.

acceptance

→ merging

I hate those CI hiccups :(

@blizzz blizzz merged commit 42121fe into master Nov 8, 2018
@blizzz blizzz deleted the fix/12319/respect-fixed-usernames branch November 8, 2018 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants