Fix displayName return of dav groups request #12389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
skjnldsv
commented
Nov 10, 2018
skjnldsv
commented
- Do not use formatted displayName for groups, we already have a function for that
- Removed unneeded displayName check for userID
skjnldsv
requested review from
rullzer,
nickvergessen,
MorrisJobke,
georgehrke and
ChristophWurst
nickvergessen
approved these changes
Nov 10, 2018
skjnldsv
force-pushed
the
fix-dav-groupid
branch
from
a01711e
to
48b5d6c
Compare
|
Failure unrelated: |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
fix-dav-groupid
branch
from
48b5d6c
to
e18548c
Compare
nickvergessen
approved these changes
Nov 10, 2018
ChristophWurst
approved these changes
Nov 12, 2018
skjnldsv
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.