Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore icons if the file could not be found #12420

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Nov 12, 2018

Otherwise it will throw an ErrorException if the file is not found.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr added bug 3. to review Waiting for reviews labels Nov 12, 2018
@juliusknorr juliusknorr added this to the Nextcloud 15 milestone Nov 12, 2018
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! 👍

@MorrisJobke MorrisJobke merged commit f6fed4d into master Nov 12, 2018
@MorrisJobke MorrisJobke deleted the bugfix/noid/icons-cacher-not-found branch November 12, 2018 20:13
@MorrisJobke MorrisJobke mentioned this pull request Nov 14, 2018
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants