Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception if decryption fails #12450

Merged
merged 1 commit into from
Nov 14, 2018
Merged

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Nov 14, 2018

For #11868

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

For #11868

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added the 3. to review Waiting for reviews label Nov 14, 2018
@rullzer rullzer added this to the Nextcloud 15 milestone Nov 14, 2018
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better ¯\_(ツ)_/¯

@nickvergessen
Copy link
Member

SHould we backport this, because of the type hinting?

@rullzer
Copy link
Member Author

rullzer commented Nov 14, 2018

Backport should be safe

@rullzer rullzer merged commit c414bd1 into master Nov 14, 2018
@rullzer rullzer deleted the fix/11868/decryption_hardening branch November 14, 2018 18:34
@MorrisJobke MorrisJobke mentioned this pull request Nov 14, 2018
24 tasks
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Nov 19, 2018
@nextcloud nextcloud deleted a comment from backportbot-nextcloud bot Nov 19, 2018
@rullzer
Copy link
Member Author

rullzer commented Nov 19, 2018

/backport to stable14

@backportbot-nextcloud
Copy link

backport to stable14 in #12540

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants