Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes dav share issue with owner #12458

Merged
merged 2 commits into from
Nov 15, 2018
Merged

fixes dav share issue with owner #12458

merged 2 commits into from
Nov 15, 2018

Conversation

georgehrke
Copy link
Member

@georgehrke
fixes dav share issue with owner
c23a66c 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke added the 3. to review Waiting for reviews label Nov 14, 2018
This was referenced Nov 14, 2018
Merged
Merged
Merged
skjnldsv
skjnldsv approved these changes Nov 14, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still working! 👍

rullzer
rullzer approved these changes Nov 15, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised!

@rullzer rullzer added this to the Nextcloud 15 milestone Nov 15, 2018
@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish 3. to review Waiting for reviews and removed 3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish labels Nov 15, 2018
@rullzer
Copy link
Member

rullzer commented Nov 15, 2018

CI is not totally happy

@MorrisJobke
Copy link
Member

@georgehrke There are a few failures in the Caldav and Carddav tests 🙈

@georgehrke georgehrke force-pushed the bugfix/dav_shares_hickup branch from 477c882 to 3a3fb07 Compare November 15, 2018 10:54
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 15, 2018
@MorrisJobke
Copy link
Member

Now only carddav only fails

@georgehrke
fix caldav tests
7179ffe 
Signed-off-by: Georg Ehrke <developer@georgehrke.com>
@georgehrke georgehrke force-pushed the bugfix/dav_shares_hickup branch from 3a3fb07 to 7179ffe Compare November 15, 2018 11:35
@MorrisJobke MorrisJobke merged commit a4d81ba into master Nov 15, 2018
@MorrisJobke MorrisJobke deleted the bugfix/dav_shares_hickup branch November 15, 2018 12:33
@georgehrke georgehrke mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@rullzer rullzer rullzer approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
4 participants
@georgehrke @rullzer @MorrisJobke @skjnldsv