Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable14] Fix wrong share popover opening on share link #12482

Merged
merged 1 commit into from
Nov 16, 2018
Merged

[stable14] Fix wrong share popover opening on share link #12482

merged 1 commit into from
Nov 16, 2018

Conversation

skjnldsv
Copy link
Member

Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com

@skjnldsv
Fix wrong share popover opening on share link
5f1f995 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug 3. to review Waiting for reviews labels Nov 16, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14.0.4 milestone Nov 16, 2018
@skjnldsv skjnldsv self-assigned this Nov 16, 2018
@MorrisJobke
Copy link
Member

To reproduce:

  • having a user/group share
  • click the "enable" on the "share link" entry
  • expected: the menu of the link opens
  • actual: the menu of the user/group share opens

@skjnldsv
Copy link
Member Author

Hum, my bad! I thought I added a more detailed comment here! :(
Thanks @MorrisJobke 🙈

MorrisJobke
MorrisJobke reviewed Nov 16, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke merged commit a79c7c7 into stable14 Nov 16, 2018
@MorrisJobke MorrisJobke deleted the share-menu-click-fix branch November 16, 2018 13:18
@skjnldsv skjnldsv changed the title Fix wrong share popover opening on share link [stable14] Fix wrong share popover opening on share link Nov 16, 2018
This was referenced Nov 19, 2018
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 14.0.4
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @MorrisJobke @rullzer