Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loader colours for better visibility #12484

Merged
merged 1 commit into from
Nov 16, 2018
Merged

Fix loader colours for better visibility #12484

merged 1 commit into from
Nov 16, 2018

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 16, 2018 •
edited
Loading

Fix #12091

Before
capture d ecran_2018-11-16_13-39-37
After
capture d ecran_2018-11-16_13-39-06
@nextcloud/designers

@skjnldsv
Fix loader colours for better visibility
8054368 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: accessibility labels Nov 16, 2018
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 16, 2018
@skjnldsv skjnldsv self-assigned this Nov 16, 2018
JanDragon
JanDragon approved these changes Nov 16, 2018
View reviewed changes
Copy link

@JanDragon JanDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ChristophWurst
Copy link
Member

better visibility

How's this better when the contrast decreases?

@skjnldsv
Copy link
Member Author

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

@MorrisJobke
Copy link
Member

@ChristophWurst on which location would the contrast be decreased?
You mean like background-dark/darker?

For the lower left image ... 🤔

@ChristophWurst
Copy link
Member

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

@skjnldsv
Copy link
Member Author

skjnldsv commented Nov 16, 2018 •
edited
Loading

Thought the spinner itself was made darker but it's actually the background, right? (Don't know where that css var is used)

It's the dark part of the spinner that got darker to increase the contrast between the light part and the dark.

juliusknorr
juliusknorr approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. 👍

MorrisJobke
MorrisJobke approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MorrisJobke MorrisJobke merged commit 8a5ac26 into master Nov 16, 2018
@MorrisJobke MorrisJobke deleted the loader-color-fixes branch November 16, 2018 13:53
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanDragon JanDragon JanDragon approved these changes

@juliusknorr juliusknorr juliusknorr approved these changes

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

Assignees

@skjnldsv skjnldsv

Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: accessibility
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
5 participants
@skjnldsv @ChristophWurst @MorrisJobke @juliusknorr @JanDragon