Apply border to primary button if on log in page (and not in a dark container) or if in header #12558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ontainer) or if in header, fix #12294 Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
jancborchardt
added
bug
help wanted
design
jancborchardt
requested review from
MorrisJobke,
schiessle,
pixelipo and
skjnldsv
Closed
I'll suggest a translucent border ( |
|
@skjnldsv could you add a commit to implement that, or give me a pointer for this? |
|
@jancborchardt sure, you need to do it on the theming scss. :) |
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
|
@skjnldsv done, I think. :) Thanks for the pointer! |
skjnldsv
approved these changes
Nov 21, 2018
|
@schiessle @MariusBluem @juliushaertl @MorrisJobke as you were involved in the "blurry buttons" issue, your review is very welcome! :) |
skjnldsv
added
3. to review
MorrisJobke
approved these changes
Nov 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #12294, please review @nextcloud/designers @schiessle
For buttons on dark background, like in the header of the share page, there still is white border:
For buttons elsewhere in the main content, where they are on white background, the border color is the same as the background color:
We could also go with
border:none;which looks even better, but then also need an exception for theming:In general we still need something for light theming colors … as usual. @juliushaertl @skjnldsv any idea? Maybe again cap the color at a specific lightness and then use the standard border color?
I am not sure whether this is something for 15 in any case as this has a bunch of potential for regressions and looking strange too.