Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix navigation more menu background for dark theme #12580

Merged
merged 1 commit into from
Nov 22, 2018
Merged

Fix navigation more menu background for dark theme #12580

merged 1 commit into from
Nov 22, 2018

Conversation

skjnldsv
Copy link
Member

@nextcloud/designers

Before After
capture d ecran_2018-11-22_10-02-30 capture d ecran_2018-11-22_10-03-56

@skjnldsv
Fix navigation more menu background for dark theme
b8cdc63 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added this to the Nextcloud 15 milestone Nov 22, 2018
@skjnldsv skjnldsv self-assigned this Nov 22, 2018
@MorrisJobke MorrisJobke mentioned this pull request Nov 22, 2018
Merged
7 tasks
MorrisJobke
MorrisJobke approved these changes Nov 22, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works 👍

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Nov 22, 2018
@MorrisJobke MorrisJobke merged commit e8df902 into master Nov 22, 2018
@MorrisJobke MorrisJobke deleted the app-navigation-menu-dark-fix branch November 22, 2018 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug design Design, UI, UX, etc. feature: accessibility
Projects
None yet
Milestone
Nextcloud 15
Development

Successfully merging this pull request may close these issues.
3 participants
@skjnldsv @nickvergessen @MorrisJobke