Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run the AnonymousOptionsPlugion on Anonymous requests #12808

Merged
merged 1 commit into from
Dec 4, 2018

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Dec 4, 2018

Fixes #12774

Signed-off-by: Roeland Jago Douma roeland@famdouma.nl

Fixes #12744

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

/backport to stable15

@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

/backport to stable14

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works again on macOS 👍

Copy link
Member

@georgehrke georgehrke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes Fantastical 👍

@MorrisJobke MorrisJobke added the 4. to release Ready to be released and/or waiting for tests to finish label Dec 4, 2018
@MorrisJobke
Copy link
Member

@rullzer Should we then release a 14.0.5 a bit ahead of time due to this?

@rullzer
Copy link
Member Author

rullzer commented Dec 4, 2018

@MorrisJobke 14.0.4 is not affected. This was merged shortly after. So no need.

@MorrisJobke
Copy link
Member

@MorrisJobke 14.0.4 is not affected. This was merged shortly after. So no need.

Puh - luckily.

@wobben
Copy link

wobben commented Dec 4, 2018

great, iCal/macOS Mojave is working again!

@rullzer rullzer merged commit 43cb51d into master Dec 4, 2018
@rullzer rullzer deleted the fix/12774/anonymous_options_only_anoynoums branch December 4, 2018 12:10
@backportbot-nextcloud
Copy link

backport to stable15 in #12811

@backportbot-nextcloud
Copy link

backport to stable14 in #12812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug high regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants